Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346304

Summary:	NPE in closing sapphire based editors
Product:	z_Archived	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Sapphire	Assignee:	Project Inbox <sapphire.ui-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	konstantin
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Shenxue Zhou

2011-05-18 13:12:10 EDT

I'm seeing many NPEs when closing sapphire based editors. Here is the stack trace:

java.lang.NullPointerException
at org.eclipse.sapphire.ui.SapphireEditorFormPage.dispose(SapphireEditorFormPage.java:117)
at org.eclipse.sapphire.ui.form.editors.masterdetails.MasterDetailsEditorPage.dispose(MasterDetailsEditorPage.java:836)
at org.eclipse.ui.forms.editor.FormEditor.dispose(FormEditor.java:403)
at org.eclipse.sapphire.ui.SapphireEditor.dispose(SapphireEditor.java:599)
at org.eclipse.ui.internal.WorkbenchPartReference.doDisposePart(WorkbenchPartReference.java:737)
at org.eclipse.ui.internal.EditorReference.doDisposePart(EditorReference.java:327)
at org.eclipse.ui.internal.WorkbenchPartReference.dispose(WorkbenchPartReference.java:684)
at org.eclipse.ui.internal.WorkbenchPage.disposePart(WorkbenchPage.java:1797)
at org.eclipse.ui.internal.WorkbenchPage.handleDeferredEvents(WorkbenchPage.java:1501)
at org.eclipse.ui.internal.WorkbenchPage.deferUpdates(WorkbenchPage.java:1485)
at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1459)
at org.eclipse.ui.internal.WorkbenchPage.closeAllEditors(WorkbenchPage.java:1262)
at org.eclipse.ui.internal.WorkbenchPage.dispose(WorkbenchPage.java:1846)
at org.eclipse.ui.internal.WorkbenchWindow.closeAllPages(WorkbenchWindow.java:887)
at org.eclipse.ui.internal.WorkbenchWindow.hardClose(WorkbenchWindow.java:1722)
at org.eclipse.ui.internal.WorkbenchWindow.busyClose(WorkbenchWindow.java:730)
at org.eclipse.ui.internal.WorkbenchWindow.access$0(WorkbenchWindow.java:715)
at org.eclipse.ui.internal.WorkbenchWindow$5.run(WorkbenchWindow.java:860)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.ui.internal.WorkbenchWindow.close(WorkbenchWindow.java:858)
at org.eclipse.jface.window.WindowManager.close(WindowManager.java:109)
at org.eclipse.ui.internal.Workbench$18.run(Workbench.java:1109)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.Workbench.busyClose(Workbench.java:1106)
at org.eclipse.ui.internal.Workbench.access$15(Workbench.java:1035)
at org.eclipse.ui.internal.Workbench$25.run(Workbench.java:1279)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.ui.internal.Workbench.close(Workbench.java:1277)
at org.eclipse.ui.internal.Workbench.close(Workbench.java:1249)
at org.eclipse.ui.internal.handlers.QuitHandler.execute(QuitHandler.java:41)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4150)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3739)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

Comment 1 Konstantin Komissarchik

2011-05-18 14:11:19 EDT

I have fixed this already. Please sync up and verify.

Comment 2 Shenxue Zhou

2011-05-18 15:08:42 EDT

Verified. closing...