Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346288

Summary: [client] Compare editor loads wrong content from diff
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED INVALID QA Contact:
Severity: major    
Priority: P3    
Version: 0.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Screenshot none

Description Szymon Brandys CLA 2011-05-18 11:36:48 EDT
I do 

GET http://localhost:8080/compare/compare.html?readonly#/git/diff/9e8fbaaf6da4a75d625f7514d6508418cdc1f227..88a0bea90bb65a885a09e1ed54fa966dd8c2fb51/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html

the response is

{"Git": {
  "Base": "/git/commit/9e8fbaaf6da4a75d625f7514d6508418cdc1f227/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html?parts=body",
  "DiffLocation": "/git/diff/9e8fbaaf6da4a75d625f7514d6508418cdc1f227..88a0bea90bb65a885a09e1ed54fa966dd8c2fb51/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html",
  "New": "/git/commit/88a0bea90bb65a885a09e1ed54fa966dd8c2fb51/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html?parts=body",
  "Old": "/git/commit/9e8fbaaf6da4a75d625f7514d6508418cdc1f227/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html?parts=body"
}}

but both sides of the compare editor tries to load

/git/commit/9e8fbaaf6da4a75d625f7514d6508418cdc1f227/file/f/bundles/org.eclipse.orion.client.git/static/js/widgets/templates/InitGitRepositoryDialog.html?parts=body

At least this is what the UI shows, see the screenshot.
Comment 1 Szymon Brandys CLA 2011-05-18 11:38:27 EDT
Created attachment 195992 [details]
Screenshot
Comment 2 Szymon Brandys CLA 2011-05-19 06:39:02 EDT
The problem happened for addition changes i.e. 9e8fbaaf6da4a75d625f7514d6508418cdc1f227 did not contain InitGitRepositoryDialog.html and the file was added in 88a0bea90bb65a885a09e1ed54fa966dd8c2fb51 . When Bug 346397 was fixed, it started to work properly.