Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346257

Summary:	path filtering in LogCommand doesn't work
Product:	[Technology] JGit	Reporter:	Piotr Janik <janikpiotrek>
Component:	JGit	Assignee:	Piotr Janik <janikpiotrek>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, Szymon.Brandys, tomasz.zarna
Version:	unspecified
Target Milestone:	1.0.0
Hardware:	PC
OS:	Windows 7
URL:	http://egit.eclipse.org/r/#change,3455
Whiteboard:
Bug Depends on:
Bug Blocks:	344683

Description Piotr Janik

2011-05-18 10:11:44 EDT

I'm trying to use LogCommand in Orion and its path filtering introduced recently (https://bugs.eclipse.org/bugs/show_bug.cgi?id=340049).
However, filtering seems to not work correctly. When I add file path, I still receive list containing all of commits. I've tried to check some JGit tests covering this functionality, but I can't see any.

Comment 1 Tomasz Zarna

2011-05-18 10:17:43 EDT

Why don't you write such a test and submit it to Gerrit. Even though it will fail it should be a value thing to start with.

It's another blocker of bug 344683, isn't it?

Comment 2 Piotr Janik

2011-05-18 10:24:11 EDT

I've already done it. ;) 
Proposed fix and unit test for path filtering: http://egit.eclipse.org/r/#change,3455

Yes, it blocks bug 344683.

Comment 3 Chris Aniszczyk

2011-05-18 11:40:20 EDT

Merged as 7449b9a297af193107560c42508c53d7adb00226.

Thanks guys!