Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346216

Summary: Regression to 3.7: 'Select All' on target preference page does nothing
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Curtis Windatt <curtis.windatt.public>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, Curtis_Windatt, daniel_megert, Michael_Rennie
Version: 3.7Flags: Michael_Rennie: review+
ankur_sharma: review+
Target Milestone: 3.7 RC2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 346336    
Attachments:
Description Flags
Fix none

Description Dani Megert CLA 2011-05-18 06:45:20 EDT 
I20110517-0800 - broken since 3.7 M3.

1. open 'Target Platform' preference page
2. click 'Edit'
3. switch to 'Content' page
4. click 'Deselect All' or deselect some entries
5. click 'Select All'
==> nothing happens (actually the items are selected but it's not shown).


In a new workspace, when I click 'Finish' and then 'Edit' again I see that the items are selected now. However, in my existing/old workspace they still don't show up selected.
Comment 1 Dani Megert CLA 2011-05-18 06:45:51 EDT 
This should get fixed for 3.7.
Comment 2 Dani Megert CLA 2011-05-18 08:27:16 EDT 
I suspect that the fix for bug 326472 broke this.
Comment 3 Curtis Windatt CLA 2011-05-18 12:51:32 EDT 
Created attachment 196003 [details]
Fix
Comment 4 Curtis Windatt CLA 2011-05-18 12:59:12 EDT 
Select all updated the tree correctly, but there is code in the content provider that also updated the tree (using information from the target that wasn't updated yet).  The change to the content provider was added so that missing plug-in errors would properly keep their check state (this is broken with the proposed fix).

For 3.7 I think this patch is the best choice.  Select all is obviously far more important than check state on errors that the user will rarely see (and only break when the filters are being used).  I looked into some alternate solutions (using preserveSelection to interrupt the filter application, changing the equals code on resolved bundles).  However, none of the changes I made fixed the issue perfectly.

I think that I should wait until 3.8 to work on a full solution and go with this patch for 3.7.
Comment 5 Curtis Windatt CLA 2011-05-18 12:59:41 EDT 
Ankur, Mike, Dani, please review asap (we only need two, but I'm not sure who is available).
Comment 6 Curtis Windatt CLA 2011-05-18 13:13:35 EDT 
To test this, open the Target Platform preference page, edit a target. Then on the content tab, do any of the following in combination:
1) Select/Deselect, double click to toggle
2) Select All/Deselect All, should change all visible
3) Filter by text, turn off source/plug-in check boxes
4) Use combo to change tree structure.

The selection count should remain correct the whole time, even if things are not visible.

Changing between plug-in/feature management should reset to all checked.

To view the problems with 'missing plug-ins' errors:
1) Add a second location to the locations tab (a second Eclipse install, etc).
2) Uncheck at least on item on the content tab from the new location
3) On the location tab, remove the new location
You should end up with missing plug-ins on the content tab.  They will not retain their check state properly if filtering is done.
Comment 7 Ankur Sharma CLA 2011-05-18 14:45:42 EDT 
+1

This looks similar to Bug 337090
Comment 8 Michael Rennie CLA 2011-05-18 15:52:53 EDT 
+1 although at one point it appeared that some bundles I had checked became un-checked after a bunch of filtering / reordering, but I could not reproduce.
Comment 9 Curtis Windatt CLA 2011-05-18 16:07:49 EDT 
Patch applied to HEAD.

Opened bug 346336 for 3.8 improvements.
Comment 10 Dani Megert CLA 2011-05-19 10:56:25 EDT 
Verified in I20110519-0800.