Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346207

Summary: Memory behaviour benchmark report charts are empty
Product: [Modeling] MoDisco Reporter: Gregoire Dupe <gdupe>
Component: TechnologiesAssignee: Nicolas Bros <nicolas.bros>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: fabien.giquel, hugo.bruneliere, Kenn.Hussey, modisco.web-inbox
Version: 0.9.0Flags: nicolas.bros: indigo+
Kenn.Hussey: pmc_approved+
gdupe: review+
fabien.giquel: review+
Target Milestone: 0.9.0 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
benchmark report
none
Statistic projet with brocken charts (benchmark run on org.eclipse.jdt.core)
none
patch none

Description Gregoire Dupe CLA 2011-05-18 05:50:18 EDT
Hello,

The Memory behaviour benchmark report charts are empty. No error is thrown in the error log.

I've reproduced this bug with the version 0.9.0.v201105171434.

Regards,
Gregoire Dupe
Comment 1 Nicolas Bros CLA 2011-05-24 04:39:27 EDT
Created attachment 196408 [details]
benchmark report

I installed MoDisco 0.9.0 RC1 from http://download.eclipse.org/modeling/mdt/modisco/updates/milestones/0.9

I launched "Discovery > Discoverers > Java Benchmark > Discover Java Model From Java Project - Benchmark". It took a long time, but eventually the html and png files appeared.
Comment 2 Nicolas Bros CLA 2011-05-24 04:40:00 EDT
works for me
Comment 3 Gregoire Dupe CLA 2011-05-25 05:53:38 EDT
Created attachment 196526 [details]
Statistic projet with brocken charts (benchmark run on org.eclipse.jdt.core)

Hello,

Here is an archive of a statistic project generated by the MoDisco Java Discoverer Memory Behavior Benchmark (0.9.0.v201105241127).  The lines are missing in the png charts.

The statistic project results from a benchmark launched on org.eclipse.jdt.core.

Regards,
Gregoire
Comment 4 Gregoire Dupe CLA 2011-05-25 05:56:25 EDT
Hello,

The bug exists and it's demonstrated by the attachment 196526 [details], furthermore the charts contained in the attachment 196408 [details] do not contain any line.

Regards,
Gregoire
Comment 5 Nicolas Bros CLA 2011-05-26 11:01:34 EDT
Created attachment 196669 [details]
patch

The curves were not visible because the scale was set to 0.
Here is a patch that fixes the problem.
Comment 6 Gregoire Dupe CLA 2011-05-27 04:20:35 EDT
Hello Kenn and Fabien,

This patch fixes the chart generation of the Java discoverer benchmark. This benchmark shows the memory behavior of the Java discoverer depending of the Java meta-model implementation (EObject, MinimalEObject, CDO, etc.)

This benchmark demonstrates the scalability limitation of the Java discoverer and the difficulty to use CDO to solve scalability problems. It’s then an important quality measurement for the project and its adopters.

This component is not delivered in http://download.eclipse.org/releases/indigo. 

It is only delivered in the MoDisco update sites:
http://download.eclipse.org/modeling/mdt/modisco/updates/release/
http://download.eclipse.org/modeling/mdt/modisco/updates/milestones/0.9

I would like to apply this patch before RC3. I think the application of the patch would be safe because it is not delivered in the http://download.eclipse.org/releases/indigo update site and the patch is really small (only two lines are modified).

Do you agree ?

Regards,
Gregoire Dupe
Comment 7 Nicolas Bros CLA 2011-05-27 11:30:50 EDT
Committed in revision 4444.
Comment 8 Gregoire Dupe CLA 2011-06-17 08:59:37 EDT
I've checked the benchmark (version 0.9.0.v201106080847): the diagrams are properly generated.

This bug can be closed.
Comment 9 Hugo Bruneliere CLA 2011-08-18 08:23:11 EDT
Bug solved.