Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346176

Summary: SDEF and Extension editor part images are not found
Product: z_Archived Reporter: Greg Amerson <gregory.amerson>
Component: SapphireAssignee: Konstantin Komissarchik <konstantin>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: konstantin
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Screenshot of the editor part image none

Description Greg Amerson CLA 2011-05-17 20:13:27 EDT
In the editor declaration for the SDEF editor and sapphire-extension.xml editor, use the icon path "src/org/eclipse/sapphire/sdk/SapphireFile.png" which resolves in the plugin.xml editor in Eclipse but does not resolve at runtime, so the Sapphire editors don't have the correct editor part image.  See screenshot.
Comment 1 Greg Amerson CLA 2011-05-17 20:13:58 EDT
Created attachment 195927 [details]
Screenshot of the editor part image
Comment 2 Greg Amerson CLA 2011-05-17 20:17:07 EDT
If you switch the path to org/eclipse/sapphire/sdk/SapphireFile.png it would resolve but then it doesn't resolve in the plugin.xml editor in PDE.  Perhaps the easiest thing is to duplicate the image in an "icons/" folder at the top level and reference it that way.
Comment 3 Konstantin Komissarchik CLA 2011-05-18 14:09:46 EDT
I have removed "src/" prefix from plugin.xml. This was added by Eclipse refactoring action and I didn't notice the problem. 

The issue with the images not being resolved in plugin.xml editor and when launching from Eclipse is Bug 160133.
Comment 4 Konstantin Komissarchik CLA 2011-06-06 12:00:13 EDT
Greg,

Could you verify this fix?
Comment 5 Greg Amerson CLA 2011-06-06 12:54:17 EDT
Verified fixed in latest build (#375)
Comment 6 Konstantin Komissarchik CLA 2011-06-06 13:50:41 EDT
Closing. Thanks for verification.