Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346148

Summary: Missing setFocus call on tab selection
Product: [Eclipse Project] e4 Reporter: Bogdan Gheorghe <gheorghe>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, pwebster, remy.suen
Version: unspecified   
Target Milestone: 4.1 RC4   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 511873    
Attachments:
Description Flags
Explicitly set the focus on a tab click none

Description Bogdan Gheorghe CLA 2011-05-17 15:51:02 EDT 
In the 3.x code,  if you click on a tab, DefaultTabFolder will listen for mouse down events and send out EVENT_GIVE_FOCUS_TO_PART which eventually calls the setFocus method in PartPane. This always gives focus to the control contained by the tab folder and never to the tab folder itself.

In 4.x, we set the focus to the control on the initial click, but if you click again on the tab, focus will go to the tab instead of remaining in the control. We need to add some code that preserves the 3.x behaviour and always gives the focus to the control.
Comment 1 Eric Moffatt CLA 2011-05-26 15:51:16 EDT 
Created attachment 196704 [details]
Explicitly set the focus on a tab click


This fixes the scenario described but still doesn't handle the case where the user clicks in an empty area on the CTF containing the currently active part... the code to fix this is quite finicky; it would have to detect that you were within the tab area to ensure that we didn't get this when clicking on the CTF's border for example...

Once Committed I'm going to mark this as fixed and we can deal with the extra case post-4.1.
Comment 2 Eric Moffatt CLA 2011-05-26 15:52:31 EDT 
Committed in >20110526. Applied the patch.
Comment 3 Eric Moffatt CLA 2011-06-06 10:07:34 EDT 
Marking as Fixed, I'll open a new defect for the remaining case fo clickingin the tab area but not on the tab...
Comment 4 Eric Moffatt CLA 2011-06-06 10:07:47 EDT 
Verified in I20110604-2201
Comment 5 Eric Moffatt CLA 2011-06-06 10:10:05 EDT 
I've opened Bug 348398 to track the remaining work.