Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346125

Summary: Exception when disposing TracingConsole
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: aleherb+eclipse, cdtdoug, pawel.1.piech
Version: 8.0Flags: aleherb+eclipse: review+
Target Milestone: 8.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fix marc.khouzam: iplog-

Description Marc Khouzam CLA 2011-05-17 13:04:20 EDT
Created attachment 195893 [details]
Fix

I'm getting a RejectedExecutionException in TracingConsole.java:85 since the fix to bug 331232.

To reproduce, run a DSF-GDB session, then terminate it but don't remove it from the launch.  Then launch a new session.  The exception is thrown.

The patch simply protects against that exception which indicates the session has been removed.
Comment 1 Marc Khouzam CLA 2011-05-17 13:05:05 EDT
Committed to HEAD.

Toni, can you review?
Comment 2 CDT Genie CLA 2011-05-17 13:23:07 EDT
*** cdt cvs genie on behalf of mkhouzam ***
Bug 346125 - Exception when disposing TracingConsole

[*] TracingConsole.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/console/TracingConsole.java?root=Tools_Project&r1=1.2&r2=1.3
Comment 3 Anton Leherbauer CLA 2011-05-18 02:55:34 EDT
Thanks, I should have considered that possibility.