Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346082

Summary: Restoring defaults on external tools preference page does not work correctly
Product: [Eclipse Project] Platform Reporter: Bia <besser>
Component: AntAssignee: Satyam Kandula <satyam.kandula>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: daniel_megert, frederic.gurr, helmut.haigermoser, Michael_Rennie
Version: 3.0Keywords: contributed
Target Milestone: 3.8 M2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch that fixes restore default behavior on external tools preference page.
none
Fix (including updated copyright) Michael_Rennie: iplog+, Michael_Rennie: review+

Description Bia CLA 2011-05-17 09:13:10 EDT
Build Identifier: 20100218-1602

After deselecting the checkboxes:

* Confirm before migrating external tool project builders for edit
* Confirm before migrating projects to the new format

on the "External Tools" preferences page, and clicking on the "Restore Defaults" button, only the first checkbox ("Confirm before migrating external tool project builders for edit") is selected again, eventhough the second checkbox should also be selected.

Reproducible: Always

Steps to Reproduce:
1.Open external tools preference page (Window -> Preferences -> Run / Debug -> External Tools) 
2. Deselect both checkboxes
3. Click on "Restore Defaults" button
4. Result: only one checkbox is selected
Comment 1 Frederic Gurr CLA 2011-05-17 09:23:34 EDT
Created attachment 195852 [details]
Patch that fixes restore default behavior on external tools preference page.

Attached a patch for this problem. Probably just a copy&paste error.
Comment 2 Dani Megert CLA 2011-05-17 10:16:22 EDT
Broken since 3.0.
Comment 3 Michael Rennie CLA 2011-05-25 10:39:23 EDT
Ant owns external tools
Comment 4 Frederic Gurr CLA 2011-07-25 06:36:01 EDT
*bump*
This issue hasn't been touched for two months now.
I know it's a minor defect, but the patch is a simple and obvious one line replacement, so it should be easy to fix.
Comment 5 Satyam Kandula CLA 2011-08-10 02:20:31 EDT
(In reply to comment #4)
Changes look good. Can you please update the copyright accordingly?
Comment 6 Frederic Gurr CLA 2011-08-10 08:39:59 EDT
Created attachment 201236 [details]
Fix (including updated copyright)
Comment 7 Michael Rennie CLA 2011-08-22 16:47:36 EDT
Applied patch to HEAD, thanks for the fix Frederic
Comment 8 Michael Rennie CLA 2011-08-22 16:48:20 EDT
verified.
Comment 9 Satyam Kandula CLA 2011-12-21 23:44:58 EST
*** Bug 367329 has been marked as a duplicate of this bug. ***