Bugzilla – Full Text Bug Listing
| Summary: | Usage of reserved words for variable names could cause problem. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] Virgo | Reporter: | Radoslav Ivanov <radoslav.ivanov> | ||||
| Component: | unknown | Assignee: | Chris Frost <eclipse> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | trivial | ||||||
| Priority: | P3 | CC: | eclipse, milesg78 | ||||
| Version: | 3.0.0.M04 | ||||||
| Target Milestone: | 3.0.0.M06 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 195833 [details]
Patch proposal for jsp-s which use "import" as variable name.
Hi, Thanks for patch, I'll have a look and probably apply it. Chris. Hi, I've checked it out and it all looks good. Can you please state that you have permission to submit this patch to eclipse and that it is your own work. Thanks. Once you have I can commit the patch. Chris. I state that I have permission to submit this patch to eclipse and it is my own work. Excellent, thank you. Need to keep the legal people happy. I've applied and pushed the patch, it will be in the next milestone. Thank you for sending the patch in in the first place, appreciated. Oh, forgot to mention. You are referenced as the author in the Git history :) |
Build Identifier: 3.0.0.M04 Hello Eventually EL 2.1 does not validate strictly the usage of words for variable names. Therefore, when I am trying to use EL 2.2., I observed the following problem on requesting Virgo Admin Console: org.apache.jasper.JasperException: /WEB-INF/jsp/state-bundle.jsp(99,6) "${import.provider eq null}" contains invalid expression(s): javax.el.ELException: The identifier [import] is not a valid Java identifier as required by section 1.19 of the EL specification (Identifier ::= Java language identifier). This check can be disabled by setting the system property org.apache.el.parser.SKIP_IDENTIFIER_CHECK to true. org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:41) I prepared a patch which I am attaching to this report. Best regards Radoslav Ivanov Reproducible: Always