Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346061

Summary:

'org.eclipse.help.webapp' has files with mixed line delimiters

Product:

[Eclipse Project] Platform

Reporter:

Dani Megert <daniel_megert>

Component:

User Assistance

Assignee:

Chris Goldthorpe <cgold>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

cgold, ChrisAustin

Version:

3.7

Flags:

ChrisAustin: review+
cgold: review+

Target Milestone:

3.7 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix	none

Description Dani Megert

2011-05-17 05:38:13 EDT

3.7 RC1.

'org.eclipse.help.webapp' has files with mixed line delimiters.

Comment 1 Dani Megert

2011-05-17 05:38:34 EDT

Created attachment 195825 [details]
Fix

Comment 2 Chris Goldthorpe

2011-05-17 12:55:45 EDT

Targeting Eclipse 3.8 - correct me if I am wrong but I don't see this as needing to be fixed for Eclipse 3.7.

Comment 3 Dani Megert

2011-05-18 02:57:48 EDT

It's not a regression, hence I'm fine with 3.8 though some apps/tools will fail when trying to read such files. Personally, I'd fix it for 3.7.

Comment 4 Chris Goldthorpe

2011-05-18 11:04:36 EDT

Targeting RC2. Chris A, please review.

Comment 5 Chris Austin

2011-05-18 12:11:53 EDT

+1 patch looks good to me

Comment 6 Chris Goldthorpe

2011-05-18 12:49:42 EDT

Looks good to me also. Patch applied to HEAD.

Comment 7 Dani Megert

2011-05-19 11:02:19 EDT

Verified in I20110519-0800.