Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346050

Summary: Requesting Discovery URL addition for non-genericserver-based JBoss server adapter
Product: [WebTools] WTP ServerTools Reporter: Rob Stryker <stryker>
Component: wst.serverAssignee: Angel Vera <arvera>
Status: RESOLVED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3 CC: raghunathan.srinivasan
Version: 3.2Flags: arvera: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
arvera: pmc_approved? (neil.hauge)
arvera: pmc_approved? (kaloyan)
arvera: pmc_approved? (cbridgha)
Target Milestone: 3.3 RC2   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/109049
Whiteboard: PMC_approved
Bug Depends on: 346049    
Bug Blocks:    
Attachments:
Description Flags
Add an indigo update site to the list of discovery urls none

Description Rob Stryker CLA 2011-05-17 04:29:05 EDT
After discussion with my team, concerns over versioning have led us to conclude that we will need a separate update-site for each major stream of wtp. 

This bug is requesting an addition to the 3.3.0 stream to add a discovery site with an indigo-specific url. 

Patch coming momentarily.
Comment 1 Rob Stryker CLA 2011-05-17 04:37:22 EDT
Targeting.

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

   This is requested by an adopter product. 

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

   There is no other way to have our update site added to the new server discovery mechanism of a newly downloaded stock wtp / eclipse installation. 

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

    No tests were performed, as our product is still ensuring that the update site is implemented. However, we have determined a hard guarantee that the update site will not need to be changed or moved around and the addresses are permanent and accurate. 

    * Give a brief technical overview. Who has reviewed this fix? 

   The fix adds one line of xml which adds a url to a list of url's. 

    * What is the risk associated with this fix? 

   The risk is near-zero for this patch. In the event the update site does not exist, the servertools UI simply recognizes that hte url does not exist and hides this from the user 100%.
Comment 2 Rob Stryker CLA 2011-05-17 04:41:45 EDT
Created attachment 195819 [details]
Add an indigo update site to the list of discovery urls
Comment 3 Angel Vera CLA 2011-05-18 16:01:25 EDT
Thanks for filling up the template Rob! that helps to speed up things. 

Even though the change is one line I still expect testing to ensure that we are loading the new entry, and to ensure that we still load the old entries.

I went ahead and did testing of your changes and didn't find a problem.
Comment 4 Angel Vera CLA 2011-05-18 17:10:11 EDT
changes committed to HEAD
Comment 5 Angel Vera CLA 2011-05-18 17:12:57 EDT
changes released to HEAD
Comment 6 Eclipse Genie CLA 2017-10-11 16:36:30 EDT
New Gerrit change created: https://git.eclipse.org/r/109049