Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346006

Summary:

Questionable paths being generated by PDE Build since 3.7M7

Product:

[Eclipse Project] PDE

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

Build

Assignee:

pde-build-inbox <pde-build-inbox>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

aniefer

Version:

4.0

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
post 3.7M7 build.xml	none

Description Chris Aniszczyk

2011-05-16 17:22:54 EDT

I believe this is related to bug 157375 being closed. I'm noticing that in the pdebuild scripts, these types of paths are being generated...


plugins/org.eclipse.pde.build/build.xml:		<mkdir dir="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208"/>
plugins/org.eclipse.pde.build/build.xml:		<unzip src="../../../../../../../../../../usr/lib/eclipse/plugins/com.ibm.icu_4.4.2.v20110208.jar" dest="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208" overwrite="false">
plugins/org.eclipse.pde.build/build.xml:			<pathelement path="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208/icu-data.jar"/>
plugins/org.eclipse.pde.build/build.xml:			<pathelement path="../../../../../../../../../../usr/lib/eclipse/plugins/com.ibm.icu_4.4.2.v20110208.jar"/>

Where in the past, we'd get something like "../com.ibm.icu_4.4.2.v20110208.jar"

Any thoughts of why this behavior changed?

Comment 1 Chris Aniszczyk

2011-05-16 17:23:59 EDT

Created attachment 195795 [details]
post 3.7M7 build.xml

Comment 2 Andrew Niefer

2011-05-17 16:08:42 EDT

Chris, I think this is just because the binary jars in the target are somewhere on disk far away from the buildDirectory.  I think that you might have seen this before the nested jar change.  We've always tried to do relative paths to help support something like the releng source build where Kim zips up the generated scripts for someone else to run.

Going from
/home/zx/eclipse/eb/org.eclipse.linuxtools.eclipse-build/eclipse-build/build/eclipse-3.7.0-I20110512-2000-src
to 
/user/lib/eclipse 

is pretty far for a relative path and in this case an absolute path would probably be better.  We could perhaps check if the relativization went all the way to the root and then just use absolute path if it did.

Comment 3 Lars Vogel

2018-12-03 09:08:44 EST

Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.