Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345925

Summary:	[xtend] validate import statements
Product:	[Modeling] TMF	Reporter:	Moritz Eysholdt <moritz.eysholdt>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	sebastian.zarnekow, sven.efftinge
Version:	unspecified	Flags:	sven.efftinge: indigo+
Target Milestone:	SR2
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Moritz Eysholdt

2011-05-16 08:06:52 EDT

steps to reproduce

1. create import-statement in xtend-file "bar.FooClass"
2. move "bar.FooClass" to "baz.FooClass"
3. in the xtend-files, type references are broken now. use content assist on a broken type reference to re-create the import statement. Now, there are two import statements, whereas "baz.FooClass" overrides "bar.FooClass" since it appears later in the list. I'd expect the old import statement to be removed.

Comment 1 Sven Efftinge

2011-05-16 08:18:08 EDT

If I understood correctly, the missing error marker for the invalid import is the problem, isn't it?

Comment 2 Moritz Eysholdt

2011-05-16 08:20:29 EDT

(In reply to comment #1)
> If I understood correctly, the missing error marker for the invalid import is
> the problem, isn't it?

that would solve (or at least prevent) this situation, too.

Comment 3 Sven Efftinge

2011-05-16 08:24:40 EDT

Import statements should be checked whether they
 - exist at all (error if not)
 - are used (warning if not)
 - static imports contains static members (error if not)

Comment 4 Sebastian Zarnekow

2011-05-17 17:01:29 EDT

See also bug 300906

Comment 5 Sven Efftinge

2011-10-13 10:05:21 EDT

We now have errors for unresolvable and warnings for unused, duplicate and wildcard imports (the latter are now deprecated). A quick fix using the organize imports action is registered for the warnings.

Comment 6 Karsten Thoms

2017-09-19 18:02:39 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 7 Karsten Thoms

2017-09-19 18:12:53 EDT

Closing all bugs that were set to RESOLVED before Neon.0