Bugzilla – Full Text Bug Listing
| Summary: | Regression to 3.7: Key Assist dialog: can't go to preference dialog via Ctrl+Shift+L | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert, emoffatt, fabiofz, markus.kell.r, pwebster, remy.suen |
| Version: | 4.1 | ||
| Target Milestone: | 4.2 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Dani Megert
*** Bug 353591 has been marked as a duplicate of this bug. *** Moving target milestone. Aggregate move to M5. Retarget to a different milestone if you wish... I've pushed a fix to Mike's GitHub (so Eric can reuse one remote). https://github.com/mrennie/eclipse.platform.ui/commit/a2bfe51f24be47e132ec949fdcda2f621a2c3f5e The problem was that the keybindings dialog was moved to the e4.bindings plug-in where it couldn't access the rest of the workbench. Moving the dialog wasn't a great option as the e4.bindings uses it as a clean way of showing the user conflicts. I ended up having a GlobalKeyAssistDialog in the workbench plug-in that extends the e4.bindings one. The global one can open up the preference page and is the dialog accessed in the bindings service (also in workbench). I didn't x-friends the internal package to workbench. I'm not sure if that is something UI typically does. *** Bug 372570 has been marked as a duplicate of this bug. *** (In reply to comment #4) > I've pushed a fix to Mike's GitHub (so Eric can reuse one remote). > https://github.com/mrennie/eclipse.platform.ui/commit/a2bfe51f24be47e132ec949fdcda2f621a2c3f5e Curtis, does the key assist page still work for multi-key bindings in the Eclipse4 only RCP apps? I just want to confirm the e4.bindings key assist dialog continues to function as it did and the 4.2 Workbench key assist dialog adds the extra functionality. PW (In reply to comment #6) > > Curtis, does the key assist page still work for multi-key bindings in the > Eclipse4 only RCP apps? I just want to confirm the e4.bindings key assist > dialog continues to function as it did and the 4.2 Workbench key assist dialog > adds the extra functionality. > > PW Yes, all the conflict resolution code and the popup dialog still exists in the bindings plug-in. I have tested this using the contacts example (changed the model to have conflicting bindings) and using a hosted workbench (used keys preference page to make a conflicting binding). Only the workbench command to open a list of possible key bindings is affected. Not sure if this is related or not, but in the contacts example, the popup text does not remove the mnemonic marker, so it shows as: &Delete &Save &Exit This doesn't happen in the workbench, so I'm guessing this is just a problem in the example due to translated string use. Pushed in >20120301. commit 9b724130f1cd5c715d15cdb19a94f64a8d4ee2c2 Thanks Curtis ! I tested this in 4.2-I20120312-1730: neither the hint is there nor does it work. (In reply to comment #8) > Pushed in >20120301. > > commit 9b724130f1cd5c715d15cdb19a94f64a8d4ee2c2 > > Thanks Curtis ! Similar to Bug 351033 this commit doesn't exist in the eclipse git repo. Eric, Paul, Remy, can one of you try cherry picking the fix on GitHub? Eric reviewed the fix and was satisfied. (In reply to comment #10) > Similar to Bug 351033 this commit doesn't exist in the eclipse git repo. Indeed, 9b724130f1cd5c715d15cdb19a94f64a8d4ee2c2 doesn't seem to exist. (In reply to comment #8) > Pushed in >20120301. > > commit 9b724130f1cd5c715d15cdb19a94f64a8d4ee2c2 Eric, where did you push this? I've pushed it to master: 421e871bcd5d3052125fe12aeaef53872f75325b Please verify this in I20120314-0100 (or later) PW . Verified in I20120314-0100. |