Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345902

Summary:

MinMaxAddon: Restore of maximized part does not work as expected

Product:

[Eclipse Project] e4

Reporter:

Christoph Keimel <c.keimel>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

minor

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

Windows XP

Whiteboard:

stalebug

Attachments:

Description	Flags
Discussion of e4 Behaviour of the MinMaxAddon	none
testcase project	none

Description Christoph Keimel

2011-05-16 05:54:59 EDT

Build Identifier: I20110501-0200

When a stack is maximized the Restore-Operation does not return the stack to its original state.

Reproducible: Always

Steps to Reproduce:
1. Create an e4 application with 2 stacks
2. Maximize one of the stacks
3. Press the restore button
=> The icon of the button will change, but the stack is not "restored"

Comment 1 Christoph Keimel

2011-05-16 05:59:07 EDT

Created attachment 195707 [details]
Discussion of e4 Behaviour of the MinMaxAddon

Comment 2 Christoph Keimel

2011-05-16 05:59:48 EDT

Created attachment 195708 [details]
testcase project

Comment 3 Eric Moffatt

2011-05-25 14:02:46 EDT

Christoph, thanks for the excellent analysis...

We know that this area still need polish but let me address a few of the issues:

A 'maximize' on a stack will take any existing stacks (other than the one being max'd) and minimize them. It will also 'tag' these stacks as 'MINIMIZED_BY_ZOOM'.

The 'restore' code for a maximized stack specifically searches for minimized stacks with the MBZ tag set and restore them.

Note that this means that if you explicitly minimize a stack then it will *not* be restored by un-maximizing the currently maximized stack...(could this be the issue?).

As far as adding specialized logic to prevent the case where someone minimizes all the stacks...I admit it's ugly (and apparently un-useful) but it is consistent behavior. I personally classify these as DIH ("Doctor it hurts"..this is from a joke where a patient says to the doctor "It hurts when I do this" and the doctor replies "Then don't do that"). IMO you can over polish something, adding unnecessary complexity to the code in order to cover extraordinary cases.

There will be much more opportunity to come back to this post 4.1 release though...;-).

Comment 4 Christoph Keimel

2011-05-26 07:33:18 EDT

Eric, I agree :-)  And you are also right: I did minimize stack-1 first before maximizing stack-2. Imho the 'MINIMIZED_BY_ZOOM' flag is already too much, because my average user will not remember if he minimized something by himself or if the app did it for him (obviously including myself :-).

Comment 5 Eclipse Genie

2019-03-26 14:36:00 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 6 Lars Vogel

2019-06-05 07:40:43 EDT

This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.