Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345898

Summary:	[server][clone] GitCloneTest#testCloneNotGitRepository prints a stack trace on console
Product:	[ECD] Orion	Reporter:	Tomasz Zarna <tomasz.zarna>
Component:	Git	Assignee:	Tomasz Zarna <tomasz.zarna>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	janikpiotrek, Szymon.Brandys
Version:	0.2	Flags:	tomasz.zarna: review+
Target Milestone:	0.3 M1
Hardware:	PC
OS:	Windows XP
Whiteboard:	gsoc2011

Description Tomasz Zarna

2011-05-16 05:30:04 EDT

The test passes but prints a stack trace on the console. This doesn't look good and may cause confusion.

!ENTRY org.eclipse.orion.server.git 4 0 2011-05-16 11:26:42.828
!MESSAGE An internal git error cloning git remote
!STACK 0
org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin
	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:142)
	at org.eclipse.jgit.api.CloneCommand.fetch(CloneCommand.java:165)
	at org.eclipse.jgit.api.CloneCommand.call(CloneCommand.java:114)
	at org.eclipse.orion.server.git.servlets.CloneJob.doClone(CloneJob.java:75)
	at org.eclipse.orion.server.git.servlets.CloneJob.run(CloneJob.java:126)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: org.eclipse.jgit.errors.NoRemoteRepositoryException: C:/Documents and Settings/Administrator/Local Settings/Temp/12752846622: not found.
	at org.eclipse.jgit.transport.TransportLocal$1.open(TransportLocal.java:130)
	at org.eclipse.jgit.transport.TransportBundleFile$1.open(TransportBundleFile.java:105)
	at org.eclipse.jgit.transport.Transport.open(Transport.java:546)
	at org.eclipse.jgit.transport.Transport.open(Transport.java:423)
	at org.eclipse.jgit.transport.Transport.open(Transport.java:307)
	at org.eclipse.jgit.transport.Transport.open(Transport.java:277)
	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:124)
	... 5 more

Comment 1 Piotr Janik

2011-07-26 15:03:43 EDT

https://github.com/pjanik/orion.server/tree/bug345898

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.

The same solution as in PushJob and FetchJob. It mutes console logging.

Comment 2 Tomasz Zarna

2011-07-27 05:58:37 EDT

*** Bug 350260 has been marked as a duplicate of this bug. ***

Comment 3 Tomasz Zarna

2011-07-27 06:15:11 EDT

(In reply to comment #1)
> The same solution as in PushJob and FetchJob. It mutes console logging.

I like the idea of unifying the way all git jobs work, so I released the fix[1], but at the same time I've filed bug 353190 to look for a better solution.

[1] http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=e91ebdb8cffb17eb3811d729e8be194b3dbde218