Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345887

Summary:

Usability: Auto-select untracked files when committing

Product:

[Technology] EGit

Reporter:

Ulli Hafner <Knut.Friedhelm>

Component:

Assignee:

Kevin Sawicki <kevin>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

matthias.sohn

Version:

0.12

Target Milestone:

1.3-M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Screenshot showing the current behavior	none

Description Ulli Hafner

2011-05-16 04:24:39 EDT

I think it would improve the usability if the commit dialog would automatically select untracked files. I think the "80% case" is that you want to check in new files. Only under rare conditions it makes not sense to check in untracked files. (At least it makes sense to have a user preference for that behavior).

Currently if you are checking in a change with several files, then the untracked files are not visible, you need to scroll first to the end of the list. So what I'm currently need to do is, open commit dialog, scroll to end of list, see if there are files missing, then select these files (or press select all). It happens quite often that I forget some files. (See also Bug 345099, which increases the problem).

(Maybe it would be another option to present untracked files in a different part of the window.)

Comment 1 Matthias Sohn

2011-06-07 20:19:50 EDT

I think this should be configurable via a preference (Commit Dialog > auto-select untracked files)

Comment 2 Ulli Hafner

2012-01-05 03:24:45 EST

Created attachment 209052 [details]
Screenshot showing the current behavior

Added a screen shot that shows the usability problems when not auto selecting new files. 

When I'm in the synchronize view then egit shows all changed files. I can select a couple of files I would like to commit in one row using CTRL-CLICK. Afterwards I select Commit from the context menu. Then the shown dialog is openend, providing a list of files that egit would like to commit. Egit selects only 4 files to commit, even though the selection contains 9 files, which is irritating (and quite cumbersome since it is not very easy to select the right files when you have a lot of touched files).

Currently, this usability problem is our #1 cause for failed builds in our team since nobody would expect that new files will not be automatically committed (even though they are selected!).

Comment 3 Ulli Hafner

2012-01-05 03:29:08 EST

Increasing the priority since this causes a lot of false compile errors in our builds.

This problem also exists if not using the synchronize view. E.g., select a package in the package explorer and right click 'Commit'. Then the commit dialog does not auto-select all files in the selected package. (Even worse, the commit dialog also shows files to commit that are NOT in the selection).

Comment 4 Kevin Sawicki

2012-01-12 13:29:39 EST

Proposed fix pushed to: http://egit.eclipse.org/r/#change,4946

Comment 5 Matthias Sohn

2012-01-12 19:23:35 EST

merged as 7db951d6ca93244409cb53fa280ccaf7027d3f9d

Comment 6 Matthias Sohn

2012-01-12 19:23:57 EST

merged as 7db951d6ca93244409cb53fa280ccaf7027d3f9d