Bugzilla – Full Text Bug Listing
| Summary: | Create unit tests for Helgrind | ||
|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Andrew Overholt <overholt> |
| Component: | Valgrind | Assignee: | Daniel Henrique Barboza <danielhb> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ebaron, jjohnstn, wainersm |
| Version: | unspecified | ||
| Target Milestone: | 0.8.1 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 350100 | ||
| Attachments: | |||
|
Description
Andrew Overholt
Re-assigning to Daniel. Created attachment 195975 [details]
Patch containing the Helgrind test suite
Hello,
I've created a JUnit tests plugin for Helgrind. The attached patch contains all the source code of the project (named org.eclipse.linuxtools.valgrind.helgrind.tests).
On the same patch I've added this new plugin into the valgrind-tests feature and added one needed line on MANIFEST.MF of Helgrind plug-in (which I only noticed missing while making this test plugin).
And, for any legal purpose, I assert that this new plug-in code was made by me, I am allowed to contribute it to this open source project and this code is being contributed under the terms of EPL.
Thanks, Daniel! It's too late to get this approved for Indigo (the IP log is due today) but I'll submit it for IP approval and then we can commit it as soon as it's approved. Daniel, can you please re-generate the patch without the .class files? Created attachment 196006 [details]
Patch containing the Helgrind test suite
Re-sending the patch without the .class files.
Daniel, is it possible for you to publish a git repository with your changes? Something on GitHub would be nice. You can fork from here: https://github.com/eclipse/linuxtools Then, we can follow this page: http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions and since I just got word that the CQ has been approved, I can pull from there and then push to the canonical git.eclipse.org repo. Let me know if this won't work and we'll figure something else out. Thanks! Hi, I'm kind of new on GitHub but I think I figured it out. My contribution is at: https://github.com/danielhb/linuxtools/commit/2153e3cb0f3c350595d589fdd94cf28115380891 Again, for any legal purpose, I assert that this new plug-in code was made by me, I am allowed to contribute it to this open source project and this code is being contributed under the terms of EPL. Let me know if any problem happens. Thanks, - daniel Created attachment 198410 [details]
diff of files in patch as attached to bugzilla and patch generated from git commit 2153e3cb0f
Thanks, Daniel. I wanted to be sure that your commit there was the same as what you attached (that which was reviewed by the Eclipse legal team). I noticed a few files different (I used the lsdiff command to look at what files were in each patch). Was this intentional? If it's a big enough divergence, we'll have to get it reviewed, especially since there appear to be more files in the git commit.
Hi Andrew, Strange, these files weren't expected. They are empty template files. Let me clean them up and commit to github again without them. Okay Andrew, think I got it right now: https://github.com/danielhb/linuxtools/commit/3103bea0dceb75a22e65f716d7cfc602a124586e Thanks, Daniel. That worked much better. I've committed this work and opened bug 350099 to track making the tests pass. Following [1], I'm marking the bug as iplog+ (since we didn't just apply the attached patch). [1] http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions I've pushed Daniel's cdd81a6ee600ef97e14fa191743415ea6457f576 and added a few changes between there and c0ad5754bd65b202b7e19591c41c3949a89b4d9e. |