Bug 345808

Comment 1 Chuong Pham 2011-05-14 08:33:14 EDT

I have been stuck on this bug for the last two weeks without a solution in sight. Any help from the EclipseLink team is much appreciated.

Comment 2 Tom Ware 2011-05-20 11:04:11 EDT

'any chance this is related to the direction of your slash characters?

The following has slashes going in multiple directions:

D:\Project\website/WebContent/META-INF

I cannot recreate this problem based on your instructions, but do get an error when I use the wrong slash character.  I can imagine the wrong slash character combining with a letter in your path to form a special character and causing an exception like this.

Comment 3 Tom Ware 2011-05-20 11:05:39 EDT

BTW: Using JDK 1.6 and Ant 1.7.1

Pasted your compiler args into a working javac command and changed only the path to the persistence.xml

Comment 4 Chuong Pham 2011-05-22 06:10:05 EDT

(In reply to comment #2)
> 'any chance this is related to the direction of your slash characters?
> 
My relative path in the build.xml file is specified as "${web.dir}/META-INF" which get translated by ANT as "D:\Project\website/WebContent/META-INF" - I have no control over ANT's path translation or the slashes.

I ran the following in the command prompt and it seemed fine:

"C:\Program Files\Java\jdk1.6.0_25\bin\javac" -Aeclipselink.persistencexml=d:\Project\website\WebContent\META-INF\persistence.xml D:\Project\website\src\java\au\com\ckd\model\BookModel.java

which led me to believe that there's a problem with EclipseLink itself.

Comment 5 Tom Ware 2011-05-24 08:34:40 EDT

What happens if you specifiy an explicit path instead of ${web.dir}

Comment 6 Chuong Pham 2011-05-26 05:08:08 EDT

(In reply to comment #5)
> What happens if you specifiy an explicit path instead of ${web.dir}

Same error using explicit path. The only way I found it to "work" is moving the META-INF directory to the same level as the ANT's build.xml - which is restrictive - I mean, why can't one have the META-INF directory under WebContent directory?

I'm baffled by this specific requirement from EclipseLink.

Comment 7 Tom Ware 2011-05-26 09:26:29 EDT

ok... there's the key (and the reason we ask for packaged test cases)  The file has to be outside of the directory subtree the classes are in.

The reason for this issue is a limitation in a JDK-provided class specific to the classes provided to use with annotation processing.

The workaround, of course, is to put a copy of your file in the same directory subtree as you are working in.

I am updating the code to expand the usecases where we work-around this issue with the JDK classes.  My recreation of the test case passes with this change.

Comment 8 Tom Ware 2011-05-26 09:30:16 EDT

Created attachment 196661 [details]
Fix - larger workaround to limitation in javax.annotation.processing.Filer

Comment 9 Tom Ware 2011-05-26 09:31:38 EDT

Checked in attached change.

Reviewed by Guy Pelletier

Tested manually using our jpa test build and the following target:

    <target name="compile-test-comp" depends="config-flat">
        <javac srcdir="${eclipselink.jpa.test}/${src.dir}"
               destdir="${eclipselink.jpa.test}/${classes.dir}"
               debug="${javac.debug}"
               debuglevel="${javac.debuglevel}"
               optimize="${javac.optimize}"
               source="${javac.version}"
               target="${javac.version}"
               deprecation="${javac.deprecation}"
               failonerror="true">
       <compilerarg value="-Aeclipselink.persistencexml=c:/temp/persistence.xml"
compiler="javac1.6" />
        <compilerarg line=" -processor
org.eclipse.persistence.internal.jpa.modelgen.CanonicalModelProcessor" />
        <compilerarg line=" -proc:only" compiler="javac1.6" />

            <include name="org/eclipse/persistence/testing/models/jpa/extensibility/**"/>
            <classpath>
			<pathelement path="C:/EclipseLinkView1/eclipselink.jar"/>
                <path refid="compile.path"/>
				<pathelement path="C:/EclipseLinkView1/jpa/eclipselink.jpa.test/eclipselink-tests.jar"/>
				<pathelement path="C:/EclipseLinkView1/foundation/eclipselink.core.test/eclipselink-tests.jar"/>
            </classpath>
        </javac>
		</target>

Comment 10 Chuong Pham 2011-05-27 17:58:21 EDT

(In reply to comment #7)
> ok... there's the key (and the reason we ask for packaged test cases)  The file
> has to be outside of the directory subtree the classes are in.

Sorry, Tom. I'll remember to include test case(s) next time. :)

> The reason for this issue is a limitation in a JDK-provided class specific to
> the classes provided to use with annotation processing.

I guess the changes you have applied will remedy any future issue with the JDK-provided class. Does the JDK development team at Oracle need to know about this issue? I suppose if they rectify the issue at the JDK-level then there won't be a need to fix at the JPA-level - not just for EclipseLink - but for other JPA implementations as well.

Comment 11 Tom Ware 2011-05-30 09:18:43 EDT

The limitation is documented, so I suspect the team is aware.  I guess users of the API just need to work around the limitation.  In this case, we missed an exception that could be thrown when we hit the limitation, and therefore didn't trigger the workaround.

Comment 12 Guy Pelletier 2013-06-18 10:26:46 EDT

*** Bug 328560 has been marked as a duplicate of this bug. ***

Comment 13 Eclipse Webmaster 2022-06-09 10:26:00 EDT

The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink