Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345746

Summary: [patch] Confusing "Update Maven Dependencies" title for the Update project configuration popup
Product: z_Archived Reporter: Fred Bricon <fbricon>
Component: m2eAssignee: Project Inbox <m2e.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: igor, mkleint, nemanjanedic, richard
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch fixing the issue igor: iplog+

Description Fred Bricon CLA 2011-05-13 11:17:58 EDT 
When clicking on update project configuration, the opened window reuses all the labels from the Update Maven Dependencies window, which can be pretty confusing. 
User can think he clicked the wrong button, or m2e is buggy and opens the wrong window
Comment 1 Nemanja Nedic CLA 2011-07-24 18:32:36 EDT 
It's still present in the 1.0 release.
Comment 2 Fred Bricon CLA 2011-08-10 08:05:41 EDT 
Created attachment 201234 [details]
Patch fixing the issue

I refactored UpdateDepenciesDialog into SelectMavenProjectsDialog, added parameters for the title and message of the dialog in the constructor.
The created 2 subclasses UpdateDependenciesDialog and UpdateConfigurationDialog, each one providing the correct UI informations.

Please review.
Comment 3 Milos Kleint CLA 2011-08-31 11:29:58 EDT 
looks ok to me.
Comment 4 Igor Fedorenko CLA 2011-09-29 20:42:21 EDT 
Applied the patch to 1.1 master HEAD. Thank you.
Comment 5 Denis Roy CLA 2021-04-19 13:24:17 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/