Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345725

Summary:

No delete relation confirmation

Product:

[WebTools] Dali JPA Tools

Reporter:

Stefan Dimov <stefan.dimov>

Component:

Diagram Editor

Assignee:

Stefan Dimov <stefan.dimov>

Status:

VERIFIED FIXED

QA Contact:

Stefan Dimov <stefan.dimov>

Severity:

major

Priority:

CC:

david_williams, jolene.moffitt, neil.hauge

Version:

3.0

Flags:

david_williams: pmc_approved+
stefan.dimov: pmc_approved? (raghunathan.srinivasan)
stefan.dimov: pmc_approved? (naci.dai)
stefan.dimov: pmc_approved? (deboer)
stefan.dimov: pmc_approved? (neil.hauge)
stefan.dimov: pmc_approved? (kaloyan)
stefan.dimov: pmc_approved? (cbridgha)
stefan.dimov: review+
neil.hauge: review+

Target Milestone:

3.0 RC2

Hardware:

All

OS:

All

Whiteboard:

PMC_approved

Attachments:

Description	Flags
patch	none

Description Stefan Dimov

2011-05-13 08:36:56 EDT

There is a regression - the deletion of relations doesn't require confirmation. It's been performed immediatly

Comment 1 Stefan Dimov

2011-05-13 09:59:29 EDT

Created attachment 195592 [details]
patch

Comment 2 Stefan Dimov

2011-05-13 10:29:39 EDT

This one is a regression and should get into RC1, because nothing should be deleted without confirmation.

There is no workaround.

The fix was tested manually. All the existing JUnit tests are passing succesfully.

The bug is result of a recent port of the editor to a newer Graphiti version. There was an API change in the Graphiti. A certain parameter was added to the method getUserDecision() of the DefaultDeleteFeature class. This way, the method is not being invoked (from the subclass DeleteRelationFeature). Instead of it another method from the super super class is being invoked and it just returns true without confirmation.

The fix is very small - i've just added a parameter to the invokation of getUserDecision(), so the risk is very low.

Comment 3 Stefan Dimov

2011-05-16 10:14:05 EDT

The fix is sbmitted and released

Comment 4 Jolene Moffitt

2011-06-14 13:05:37 EDT

Verified in Build I-3.3.0RC4-20110603221533

Verified delete message within diagram editor appears as follows when you want to delete an entity relationship - Do you want to remove this relation from the diagram and update the corresponding Java resouces?  See the link to view test steps for verification. http://wiki.eclipse.org/Dali_3.0_RC2