Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345571

Summary:	Improve 'Git Tree Compare' view
Product:	[Technology] EGit	Reporter:	Paweł <pawelec_p>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	carolynmacleod4, daniel_megert, matthias.sohn, nicolas.bros, remy.suen
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	396972

Description Paweł

2011-05-12 06:38:00 EDT

Build Identifier: 0.12

I found that this window is very usefull for code review. I can edit file locally with this window.

I think it would be very usefull to improve this window with:
- Expand whole tree button
- "open" / "open in" on right click
- "Link with editor" button - open file in compare editor should then select file in Package Explorer/Navigator (like in standard eclipse editor)
- On right click: overwrite changes with (select branch)
- It would be great if "compare editor" allow to execute actions like "format code", "optimize imports", etc... SVN plugin does it.


Reproducible: Always

Comment 1 Carolyn MacLeod

2012-02-22 15:57:09 EST

Agree. I have changed the priority to "normal" instead of "enhancement" because the missing "Expand All" feature is more than just annoying when one has many changes to drill down into... it takes a lot of time, and makes this view almost useless.

In the CVS compare view, Expand All was on the context menu of any folder node.
I would be fine with a [+] tool in the view toolbar, which expands all folders.

This view also needs Next Difference (ctrl+.) and Previous Difference (ctrl+,) tools (yellow down arrow icon and up arrow icon, respectively). Note that these tools must cycle through every change of every file... not just the first change in each file.

The "Show files with equal content" tool that is currently in this view is using the wrong icon - the yellow left and right arrows icon is reserved for "Link with Editor", which would be a nice feature for this view.

I agree with having "Open", "Open With", and "Show In" (i.e. History) on the context menu (in addition to "Open in Compare Editor" which is the default action on double-click).

Also, "Overwrite" (aka "Reset...") is crying to be in the context menu for any file in this view.

Another useful one would be "Create Patch...".

In summary, the "Git Tree Compare" view needs a lot more functionality to be truly useful, but the one thing that is really needed is "Expand All".

Comment 2 Carolyn MacLeod

2012-02-23 10:49:11 EST

See also bug 358394.

Comment 3 Carolyn MacLeod

2012-03-08 16:07:44 EST

Pawel, FYI I found a workaround for expanding the whole tree in this view.
If you are on Windows, and if you have a full keyboard, typing * on the numpad will expand the whole tree. (This works for me on XP. I assume it also works on Win7).

Comment 4 Carolyn MacLeod

2012-03-09 12:30:15 EST

If you are on Mac, the workaround for expanding a tree view is to type Alt+Right arrow.

Comment 5 Dani Megert

2012-08-28 11:27:05 EDT

(In reply to comment #0)
> - Expand whole tree button
See bug 376241.

And for the context menu, see bug 355637.

Comment 6 Nicolas Bros

2012-11-07 03:38:14 EST

+1
I use the "Git Tree Compare" view a lot, to review changes before committing them.

Comment 7 Nicolas Bros

2012-12-20 02:59:28 EST

"Refresh" would be nice too (cf Bug 396972).