Bugzilla – Full Text Bug Listing
| Summary: | [metatype] Metatype Service tries to read directory entries and fails | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Christoph Laeubrich <laeubi> | ||||
| Component: | Compendium | Assignee: | John Ross <jwross> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | jwross, tjwatson | ||||
| Version: | unspecified | ||||||
| Target Milestone: | Juno | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Christoph Laeubrich
I'm going to queue this up for 3.8. The message appears because of some calls to printStackTrace() within the DataParser.doParse() method. We may want to remove those and possibly replace them with a DEBUG log message. This exception does not prevent metadata XML resources within the OSGI-INF/metatype directory from being processed. We may also want to consider whether or not it would be worthwhile to expand the search for metadata XML resources to all sub-directories of OSGI-INF/metatype. Currently, all resources are expected to be directly underneath the metatype directory. A strict interpretation of the spec seems to support this. 105.7 (pg 114) A bundle that wants to provide meta type resources must place these resources in the OSGI-INF/metatype directory. The name of the resource must be a valid JAR path. All resources in that directory must be meta type documents. However, it might be a nice feature of the implementation to support recursive searches. (In reply to comment #1) > However, it might be a nice feature of the implementation to support recursive > searches. I would not suggest deviating from the specification on this. If the specification does not allow recursive searches, then I would not suggest we add support for that. Usually that just opens us up for bugs about not complying with the specification. Or are you suggesting that the specification is not clear on if recursive searches should be done or not? > Or are you suggesting that the specification is not clear on if recursive
> searches should be done or not?
I also think the specification is a bit unclear:
In the introduction it say's "OSGI-INF/metatype directories must be scanned for any XML resource"
In my opionion this would include searching recursive... but as quoted above by John W Ross if it has to 'All resources in that directory must be meta type documents' and a folder is also a "resource" but not a metatype document... er... confusing :)
The problem is still, that for SVN I can't hold the 'All resources in that directory must be meta type documents' rule:-\
Beside this, generating a warning/debug info might be the best solution in my opinion.
(In reply to comment #2) > Or are you suggesting that the specification is not clear on if recursive > searches should be done or not? Yes, I'm suggesting that might be open for debate. What I posted in my previous comment is the only thing I can find in the spec that might support the argument that recursive searches are prohibited. Move all 3.8 bugs to Juno. Unfortunately, the work done in bug 350201 and bug 346804 didn't help here. An error message will still be logged if any URL returned by BundleWiring.findEntries does not point to a valid metadata XML file. Assuming we're not interested in supporting recursive searches, one thing to do would be to disable recursive searches on findEntries by setting the FINDENTRIES_RECURSE option. This would alleviate but not completely solve the issue since directory entries off the root level would still be returned. We could potentially use a filePattern of "*.xml", but the spec does not require metadata files to end in that extension. I wonder if it would be worthwhile to suggest a new option be added to BundleWiring.findEntries along the lines of FINDENTRIES_NODIRS. (In reply to comment #6) > I wonder if it would be worthwhile to suggest a new option be added to > BundleWiring.findEntries along the lines of FINDENTRIES_NODIRS. No, although the javadoc does not appear to be clear on this point; I think URLs to directory entries should end with '/'. I think our implementation can safely ignore URLs with a path ending in '/'. Created attachment 198990 [details]
proposed patch
This patch disables recursive searches for BundleWiring.findEntries and ignores entries that end with '/'.
Patch released. |