Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345556

Summary:

Improve EMF Facet Table Tests performance

Product:

z_Archived

Reporter:

Nicolas Guyomar <nicolas.guyomar>

Component:

EMF-Facet

Assignee:

Gregoire Dupe <gdupe>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

emft.facet-inbox, gdupe

Version:

unspecified

Flags:

gdupe: indigo+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch for Bug 345556	none
Patch for Bug 345556 performance enhancement	gdupe: iplog+

Description Nicolas Guyomar

2011-05-12 05:23:30 EDT

Hi,

Tests for EMF Facet Table are particularly slow because we are importing the whole test plugin for every test we perform.

We should create a new project and copy only what we need for the test in it.

Regards,
Nicolas Guyomar

Comment 1 Nicolas Guyomar

2011-05-13 09:06:28 EDT

Created attachment 195588 [details]
Patch for Bug 345556

Hi,

Please find attached a patch which remove the use of PluginUtils.importPlugin() from the test in order to be replaced with a project creation, populated with the only necessary elements

This way, tests are much faster (nearly 1.5min per test before, 30sec now on my computer)

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 2 Nicolas Guyomar

2011-05-16 04:15:57 EDT

Created attachment 195694 [details]
Patch for Bug 345556 performance enhancement

Hi,

The previous patch was incomplete and moreover contained a resource with outdated uri.

I've added the Command handlers performance enhancement and fixed the uris in tableTestNatTableAPITest.table

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 3 Gregoire Dupe

2011-05-16 07:43:00 EDT

Comment on attachment 195694 [details]
Patch for Bug 345556 performance enhancement

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I’ve committed this patch except the modification of /org.eclipse.emf.facet.widgets.nattable.tests/resources/testUiResources/_test_tableEcoreTest.table because we have to check that files that can be opened with an old version can also be opened with the last version (except for files created with a version released between M1 and M6) until that the file format has been officially deprecated.

Committed revision 652.

Comment 4 Gregoire Dupe

2011-05-16 07:43:48 EDT

This bug can be marked as fixed.

Regards,
Gregoire Dupe

Comment 5 Gregoire Dupe

2011-06-08 10:13:24 EDT

This bug can be closed.