Bugzilla – Full Text Bug Listing
| Summary: | Compilation errors in HEAD | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Common Tools | Reporter: | Rob Stryker <stryker> | ||||
| Component: | wst.common | Assignee: | Rob Stryker <stryker> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Carl Anderson <ccc> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cbridgha, ccc | ||||
| Version: | 3.2.3 | Flags: | ccc:
pmc_approved?
(david_williams) ccc: pmc_approved? (raghunathan.srinivasan) ccc: pmc_approved? (naci.dai) ccc: pmc_approved? (deboer) ccc: pmc_approved? (neil.hauge) ccc: pmc_approved? (kaloyan) cbridgha: pmc_approved+ ccc: review+ |
||||
| Target Milestone: | 3.3 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
Created attachment 195458 [details]
Compilation error patch
*** Bug 335074 has been marked as a duplicate of this bug. *** fixes look good Committed to HEAD for WTP 3.3 RC1 Note that, since these were the *ONLY* changes to these plugins for this release, I increased the plugin version ids, also. |
There are several compilation errors in HEAD as follows: 1) AscendingGroupComparator - Potential NPE 2) DescendingGroupComparator - Potential NPE 3) ErrorDialog - Field name hiding superclass field name The solutions are as follows: 1) Move the casts above the null check 2) Move the casts above the null check 3) Rename the subclass field by adding a "2" at the end of the field name Pre-emptively filling out the PMC reviews: * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. It's unprofessional and unacceptable to have a repository for an upcoming major release which, were a user or adopter to check out from a tag, be non-compilable. These patches fix that. * Is there a work-around? If so, why do you believe the work-around is insufficient? The workaround is for the user to check out the common tools plugins, and change each plugin's compiler settings to be more liberal with errors, or, for a user to manually fix the errors himself. Either way leaves the user with a workspace inconsistant with head. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? The patch has merely been smoketested. All variable renames were done via the eclipse rename refactor mechanism, which, if JDT is to be trusted, changed only those variables which were already using the subclass's version of the variable. * Give a brief technical overview. Who has reviewed this fix? Casts were moved above the null checks to remove the errors. Fields hiding superclass fields were renamed by adding a "2" at the end of the name. Unused fields were removed. * What is the risk associated with this fix? Risk is very low.