| Summary: | [Dialogs] Blank line in edit dialog | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Alex Blewitt <alex.blewitt> | ||||||||||
| Component: | UI | Assignee: | Stefan Xenos <sxenos> | ||||||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||||||
| Severity: | minor | ||||||||||||
| Priority: | P3 | CC: | dirk_baeumer | ||||||||||
| Version: | 2.1 | ||||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | Macintosh | ||||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Blewitt
The blank line is used for status messages. Are you on RC2? We have changed the background so that it is SWT background color. Not sure that we can make it any better. Dirk? On Mac, the background for this status box is white, as opposed to the standard Mac background colour (a kind of stripey-grey). There are dialogs with status messages that don't have the white background; the labels that show a (shared) project's CVS information have the grey background, so some types of SWT label don't have this feature. However, the project properties (name, location etc.) do have the white background, but I'd always assumed that this was because they could be changed whereas the CVS stuff can't -- or is this another example of the bug? If you've not got a Mac handy to see the glitch, I can attach screenshots ... JDT/UI is setting the background to JFaceColors.getErrorBackground, which is conformant to Eclipse UI (the do the same for their dislogs). Moving to platform for comments. The problem is that we use JFaceColors.getBannerBackground(display) which is SWT.COLOR_LIST_BACKGROUND. This was by design - it is not meant to be the same as the background. Reopening bug because of differences between Windows and Mac behaviour. When there is no text, the Windows box shows no indication that there is a label present. It is only when something is changed that the background appears. When there is no text, the Macintosh box draws a background box which is /not/ the Mac background. When text is shown, both Mac and Windows show a diffreent coloured background. See attachments for differences between Windows and Mac platform. Created attachment 4425 [details]
Mac with no selection
Showing Preferences -> Classpath Variables -> Edit dialog
No selection
Note the white line where the label is at the bottom
Created attachment 4426 [details]
Mac with selection error
Mac with selection error
Background subtly highlights error (though IMHO not in a clear way)
This is similar to the Windows selection
Created attachment 4427 [details]
Windows with no selection
Windows with no selection
Created attachment 4428 [details]
Windows with selection error
Windows with selection error
Note the slight grey background, which is similar to the one with the mac
selection error
*** This bug has been marked as a duplicate of 71765 *** Yeah, dupe. |