Bugzilla – Full Text Bug Listing
| Summary: | [Tooling] Provide link to create a RAP application | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Holger Staudacher <holger.staudacher> | ||||||||
| Component: | Tools | Assignee: | Project Inbox <rap-inbox> | ||||||||
| Status: | NEW --- | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Holger Staudacher
Created attachment 199112 [details]
new welcome page action
This patch adds a new action to the welcome page (like the install target action) that opens the new project wizard. With the APIs available from the new project wizard it is not possible to browse directly to the template section. It is possible to set e project name and select a template before the dialog is opened. Therefore, the provided action sets the project name "org.eclipse.rap.mail.demo" and selects the mail template before new plugin project wizard is opened.
Sorry but this patch is not an option. It's simply not clear what it does. I mean, it's ok that pde does not provide a way to jump to the template section. But a normal developer can't understand what happens here. He clicks the link on the welcome page an the wizard opens, so far so good. When he clicks next two times he comes to the template section. Nothing is pre selected in the UI but when he clicks finish a project will be created using the mail template. This is black magic ;) The only valid solution in this case would be to just open the new plug-in project wizard without selecting a template. This would avoid the need to know that you need to create a plug-in project. I think we can do this with your patch when it's a little reworked. When you rework the patch please consider the following: - The patch harms our coding conventions. - The strings are not internationalized. - The picture used for the new link is meaningless. Why did you used the this picture? Created attachment 199335 [details] updated patch >- The patch harms our coding conventions. This corrected now. >- The strings are not internationalized. I didn't find any strings to internationalize. Which strings do you mean? The patch doesn't select anything in the new plug-in wizard. The wizard is just opened. Also the description on the welcome page has been changed. Created attachment 199336 [details]
RAP Demo Icon
>The picture used for the new link is meaningless. Why did you used the this picture?
I don't think that it is meaningless. It isn't the optimal one but can be associated with a RAP Demo application. Anyway, here is another suggestion. Should be placed into the folder intro->graphics
Thats the point, Strings that are not internationalized should have a NON-NLS marker. In your Action there are two string missing this. It is Friday late in the afternoon :). They are no more there. |