Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345401

Summary: [validation] one of each of the warning() and error() methods drop issue data
Product: [Modeling] TMF Reporter: Knut Wannheden <knut.wannheden>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sebastian.zarnekow
Version: 2.0.0Flags: sebastian.zarnekow: indigo+
Target Milestone: RC1   
Hardware: All   
OS: All   
Whiteboard:

Description Knut Wannheden CLA 2011-05-11 07:24:19 EDT
The methods AbstractDeclarativeValidator#error(String, EStructuralFeature, String, String...) and the corresponding AbstractDeclarativeValidator#warning(String, EStructuralFeature, String, String...) drop the passed issueData parameter:

	protected void error(String message, EStructuralFeature feature, String code, String... issueData) {
		error(message, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code);
	}

	protected void warning(String message, EStructuralFeature feature, String code, String... issueData) {
		warning(message, state.get().currentObject, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code);
	}

The methods should instead read:


	protected void error(String message, EStructuralFeature feature, String code, String... issueData) {
		error(message, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code, issueData);
	}

	protected void warning(String message, EStructuralFeature feature, String code, String... issueData) {
		warning(message, state.get().currentObject, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code, issueData);
	}
Comment 1 Sebastian Zarnekow CLA 2011-05-13 08:45:37 EDT
Pushed to master.
Comment 2 Karsten Thoms CLA 2017-09-19 17:01:05 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:12:28 EDT
Closing all bugs that were set to RESOLVED before Neon.0