Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345324

Summary: CheckboxMultiSelectAttributeEditor should only call attributeChanged once per change
Product: z_Archived Reporter: Sam Davis <sam.davis>
Component: MylynAssignee: Sam Davis <sam.davis>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: steffen.pingel
Version: unspecified   
Target Milestone: 3.6   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
patch
steffen.pingel: iplog+
mylyn/context/zip none

Description Sam Davis CLA 2011-05-10 15:16:14 EDT 
The buttonPressed method calls setValues and then attributeChanged, but setValues itself calls attributeChanged, resulting in duplicate notification. buttonPressed should not directly call attributeChanged.
Comment 1 Sam Davis CLA 2011-05-10 15:16:48 EDT 
Created attachment 195265 [details]
patch

Steffen, here's a small patch.
Comment 2 Steffen Pingel CLA 2011-05-10 16:14:25 EDT 
Thanks. I'll look at the patch in the next couple of days.
Comment 3 Steffen Pingel CLA 2011-05-16 14:42:34 EDT 
Thanks Sam. I have applied the patch.
Comment 4 Steffen Pingel CLA 2011-05-16 14:42:36 EDT 
Created attachment 195777 [details]
mylyn/context/zip