Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345323

Summary: Delete confirmation doesn't provide complete information
Product: [WebTools] Dali JPA Tools Reporter: Ram Venkataswamy <ram.venkataswamy>
Component: Diagram EditorAssignee: Bistra Yakimova <bistra.yakimova>
Status: VERIFIED FIXED QA Contact: Stefan Dimov <stefan.dimov>
Severity: normal    
Priority: P3 CC: david_williams, jolene.moffitt, neil.hauge, petya.sabeva, tranle1
Version: 3.0Flags: david_williams: pmc_approved+
stefan.dimov: pmc_approved? (raghunathan.srinivasan)
stefan.dimov: pmc_approved? (naci.dai)
stefan.dimov: pmc_approved? (deboer)
stefan.dimov: pmc_approved? (neil.hauge)
stefan.dimov: pmc_approved? (kaloyan)
stefan.dimov: pmc_approved? (cbridgha)
stefan.dimov: review+
neil.hauge: review+
Target Milestone: 3.0 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
Added detailed delete information when deleting one or more entities or a relation
none
patch v2 none

Description Ram Venkataswamy CLA 2011-05-10 15:12:57 EDT 
Build Identifier: I20110310-1119

Delete confirmation doesn't provide complete information

Reproducible: Always

Steps to Reproduce:
- open JPA diagram editor

- right click "Show All Entities" or drag and drop an entity from project explorer

- now, select an entity and delete

With respect to the "show entity..." I was expecting the delete operation would remove ONLY the rendering of the entity on the editor. Instead the delete removes the entity from the project (deletes the java file and entry from persistence.xml file).

The confirmation message for delete provides only "Do you really want to delete?" 

I feel this isn't provide enough information. It would be useful to provide little more information like "Are you sure to delete <entity-name> from the project and update persistence.xml?"
Comment 1 Stefan Dimov CLA 2011-05-11 05:06:17 EDT 
Yes, I guess the confirmation message might be confusing. It won't hurt to make it more clear.
Comment 2 Bistra Yakimova CLA 2011-05-18 09:06:28 EDT 
Created attachment 195969 [details]
Added detailed delete information when deleting one or more entities or a relation
Comment 3 Stefan Dimov CLA 2011-05-18 12:02:20 EDT 
Created attachment 195999 [details]
patch v2

The original patch is fine, I just made a little adjustments.
Comment 4 Stefan Dimov CLA 2011-05-18 12:09:32 EDT 
This patch is not critical, but is relatively small, so I believe it should get into RC2.

No workaround.

The fix has been tested manually and all the exisiting JUnit tests are passing successfully.

The fix adds implementaion(s) of the inherited method getUserDecision(), which does nothing but to open a confirmation dialog and return false/true indicating if the user wants to proceed with deleting. The fix also makes confirmation questions a bit more detailed. I've reviewed the fix.

The fix is relatively small and the risk is low.
Comment 5 Neil Hauge CLA 2011-05-18 15:00:35 EDT 
I have been confused by this myself, and I suppose in a worst case scenario this could result in data loss.  As a result, I think it meets the criteria for RC2.
Comment 6 David Williams CLA 2011-05-19 14:12:33 EDT 
sounds good for RC2
Comment 7 Tran Le CLA 2011-05-19 15:34:18 EDT 
Patch committed in RC2
Comment 8 Neil Hauge CLA 2011-05-19 15:59:55 EDT 
.
Comment 9 Jolene Moffitt CLA 2011-06-14 12:37:45 EDT 
Verified in Build I-3.3.0RC4-20110603221533

Verified delete message within diagram editor appears as follows - Do you want to remove the entity "ADDRESS" from the diagram and delete the corresonding Java resouce "moel.ADDRESS"?  See the link to view test steps for verification. 
http://wiki.eclipse.org/Dali_3.0_RC2