Bugzilla – Full Text Bug Listing
| Summary: | [client] git repo page - does it need checkboxes? | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Szymon.Brandys |
| Version: | 0.2 | Flags: | Szymon.Brandys:
review+
|
| Target Milestone: | 0.2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Susan McCourt
I think that Delete may be a selection based action. We plan to add it during M8. Gosia, I would mark it as INVALID once we have Delete on the repo view. (In reply to comment #1) > I think that Delete may be a selection based action. We plan to add it during > M8. Gosia, I would mark it as INVALID once we have Delete on the repo view. Yes, I added the multiselection when for a while we has "Delete" mock action. Soon it will be needed again ;) cool, (don't forget some spacing!) that is what caught my eye. The delete command was added and now there is no doubt that we need checkboxes. do we really need multi-select delete command? - it's only relevant for top level repos - it already appears in the actions column - it appears in the toolbar as an icon which is not our standard Couldn't we just contribute it for "object" scope so it appears only in the column on relevant entries? And if we don't need that command, can we lose the checkboxes? The reason I'm harping on this is that you have to get really deep in the clones tree to do anything, and the checkboxes become visual clutter. (At least in the navigator you can drill in at each level so it's rare to have more than a level or so expanded...not to mention that move/copy and other parameterized actions would be very tedious without grouping them.) (In reply to comment #5) > do we really need multi-select delete command? > - it's only relevant for top level repos We could delete multiple branches or remotes too. > - it already appears in the actions column 'Delete' in the navigator also appears twice, in the object toolbar and the main toolbar. > - it appears in the toolbar as an icon which is not our standard That's another bug. Gosia, please raise a separate bug for it and fix it. (In reply to comment #6) > (In reply to comment #5) > > do we really need multi-select delete command? > > - it's only relevant for top level repos > > We could delete multiple branches or remotes too. I only saw the delete button appear when selecting the top level repo (in the latest code pulled last night). > > - it already appears in the actions column > > 'Delete' in the navigator also appears twice, in the object toolbar and the > main toolbar. Yes, only because we already have the menu for move/copy. Move copy is not practical for single selection because you have to specify a target each time. > > > - it appears in the toolbar as an icon which is not our standard > > That's another bug. Gosia, please raise a separate bug for it and fix it. I personally would prefer losing the checkboxes and the toolbar delete. You can always add them back if you expand the delete cases or add other multi select actions. checkboxes removed. |