Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345176

Summary: [diagram] Support deleting of bend points
Product: z_Archived Reporter: Konstantin Komissarchik <konstantin>
Component: SapphireAssignee: Shenxue Zhou <shenxue.zhou>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 Keywords: usability
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Konstantin Komissarchik CLA 2011-05-09 14:11:41 EDT 
Once you create a bend point, no facility exist to delete it. Deleting and re-creating a connection is the only option. This can be very frustrating for users as the connection can have more data attached to it than the two end points.

We should add two actions that would be accessible via a context menu.

1. In connection bendpoint context, implement existing delete action.
2. In connection context, implement new "delete all bendpoints" action.
Comment 1 Konstantin Komissarchik CLA 2011-11-02 22:09:58 EDT 
Bulk deferral of diagram-related items to the 0.5 release.
Comment 2 Shenxue Zhou CLA 2012-03-12 17:07:32 EDT 
Deletion of bend points one at a time is actually supported. When a connection with bend points is selected and the cursor is moved close to a particular bend point, the cursor changes to cross-with-arrows shape. If you click and drag, the bend point is moved. But if the bend point is moved towards the straight line between the two points at the each side of the bend point on the connection, the UI gesture is interpreted as a request to delete the bend point. 

The difficulty in providing "delete" context menu on a single bend point is we don't have the concept of selecting a single bend point on a connection. When a connection is selected, all the bend points on it are highlighted. On the other hand, we could provide a "delete all" context menu on a connection to remove all the bend points on it.

Does this make sense?
Comment 3 Konstantin Komissarchik CLA 2012-03-12 17:27:36 EDT 
I would be fine with a "delete all bend points" action.
Comment 4 Shenxue Zhou CLA 2012-03-13 12:12:01 EDT 
Added "delete all bendpoints" action on connections.
Comment 5 Konstantin Komissarchik CLA 2012-03-13 16:02:52 EDT 
1. The action should not be defined/implemented in the gef renderer. It should be fully implemented in the main ui plugin.

2. We should treat "bend points" as two separate words as it is the most common usage today, contrary to GEF's approach of making it one word. Please update the action label, classnames, ids, etc. accordingly.

3. There needs to be a section for this in the enhancements doc.
Comment 6 Shenxue Zhou CLA 2012-03-20 16:35:31 EDT 
Moved the action to the main ui plugin.
Renamed "bendpoint" to "bend point" in class names, action labels etc.
Added a note in enhancement doc.
Comment 7 Konstantin Komissarchik CLA 2012-03-21 00:05:03 EDT 
Verified. Closing.

I moved the delete all bend points action to show up next to the delete action. I also tweaked the wording in the enhancements doc. The enhancement doc could use a screen capture of this, but we need to wait on that until there is no "direct edit" action in the context menu. Will open a separate bug on that.