Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345165

Summary:	Special character replacement in extension xml should recognize already translated characters
Product:	[Eclipse Project] PDE	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	alexander.fedorov, daniel_megert, Vikas.Chandra
Version:	3.7	Keywords:	investigate
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug
Bug Depends on:	342512
Bug Blocks:

Description Curtis Windatt

2011-05-09 12:10:02 EDT

1) In a plug-in xml, select an extension that uses a label that can use mnemonics.
2) Change the label to 'TEST&ATEST' and save.
At this point the UI will show the label as TEST&ATEST while the xml should be TEST&amp;ATEST
3) Change the label to 'TEST&amp;ATEST' and save
Now the xml will be converted to 'TEST&amp;amp;ATEST'

The replacement is done in XMLInputContext.getWritableAttributeNodeValue which calls out to another utility method.  Rather than do a straight string replacement, the code should check whether the replacement has already been done.

What makes this worse for the user, is that extension point documentation often assumes you are editing the xml by hand.  It encourages you to enter &amp; in the label.

Comment 1 Eclipse Genie

2019-05-11 01:11:53 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 2 Eclipse Genie

2021-05-01 06:42:35 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 3 Eclipse Genie

2023-04-22 03:03:52 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.