Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345013

Summary:	[tools] Command line mirror application has no way to set raw = false
Product:	[Eclipse Project] Equinox	Reporter:	Andrew Niefer <aniefer>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	anthony.dahanne, pascal, sebastien.angers
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Andrew Niefer

2011-05-06 14:49:25 EDT

From bug 338878 comment #6

By the way, there seems to be a bug in
org/eclipse/equinox/p2/internal/repository/tools/MirrorApplication.java since
the value of the "raw" attribute can't be changed; default value is "true" and
in initializeFromArguments(String[] args) we have

   if (args[i].equalsIgnoreCase("-raw")) //$NON-NLS-1$
                raw = true;

so, it can only (not) change from "true" to "true".  So, it seems that there's
no way to use "false" from MirrorApplication at command line. (maybe there
should be property -falseRaw (just kidding)).

Comment 1 Sebastien Angers

2011-05-06 15:42:38 EDT

- Option A) change the default value of the 'raw' attribute from 'true' to 'false' in the Mirror Application; which kind of make sense in the Use Cases I've seen, but would change the current behavior (and would like to have more feedback on this option).  

- Option B) change 'raw' from "arg without parameters" (aka a flag) to "arg with parameters"

Comment 2 Pascal Rapicault

2011-05-17 20:07:06 EDT

We tried to keep the command line apps to a minimum number of arguments. Instead we provide ant tasks with all the bells and whistle. Please provide a patch if you want to see this fixed. Thx.

Comment 3 Sebastien Angers

2011-05-17 20:27:18 EDT

(In reply to comment #2)
> We tried to keep the command line apps to a minimum number of arguments.
> Instead we provide ant tasks with all the bells and whistle. Please provide a
> patch if you want to see this fixed. Thx.

Understood/Agreed, (and we use it from Ant, but it was just logged since it's a defect) but in Comment 1, feedback was asked about if "raw" attribute could simply be initialized to 'false' instead of 'true' (the bug is that using the 'flag' in the application will turn it from 'true' to 'true').  

Or, I'll provide patch for both options (both very simple) and let the Committer decide which one to commit :-)

Comment 4 Eclipse Genie

2019-06-02 19:27:30 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.