Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344980

Summary:

Save search is broken

Product:

[ECD] Orion

Reporter:

John Arthorne <john.arthorne>

Component:

Client

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

simon_kaegi

Version:

0.2

Flags:

john.arthorne: review+

Target Milestone:

0.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
diff	none

Description John Arthorne

2011-05-06 10:51:29 EDT

20110506

1) Starting in the Navigator, enter search term "foo" in the search field and hit enter
2) On the search results page, click "Save Search"
3) On the same page, enter another search term "bar" and hit enter
4) On the new search results page, click "Save Search"

-> It saves the "foo" search again, instead of the "bar" search.

Comment 1 Simon Kaegi

2011-06-09 11:08:03 EDT

This is still an issue. Also, the search page neeeds the global commands header stuffs.

Comment 2 Susan McCourt

2011-06-09 12:52:04 EDT

Weird, some of the globalCommands stuff is there, but not the "primary nav links" extension stuff.

This could be another one of those race condition things?

Simon, is there something we do on a page to ensure that certain plug-ins are installed?

Comment 3 Susan McCourt

2011-06-09 16:43:16 EDT

Created attachment 197739 [details]
diff

Two things fixed:

- this page apparently never had the pass done on it where we load the plugin registry first and then start loading services and global commands, etc.  (In fact this page never before used the plugin registry).  This wouldn't have mattered when the primary nav links were hard-coded.  But once those moved to an extension (in M8), then this page no longer had the links.
- the command that gets generated for save was never updated when the hash was updated for a new search query

Comment 4 Susan McCourt

2011-06-09 16:46:45 EDT

adding review for John.

You can review the attached diff.
Or you can find a branch called bug344980.

If you are looking at this on Friday and approve, could you please push it for me?  If it's today I can push it.

Comment 5 John Arthorne

2011-06-10 09:19:19 EDT

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=41a91f907e0c87355880c00618a09526c31dec5a

Performed my first cross-branch merge with the Orion git UI! It's so cool that I could push this change but the author information still shows Susan.