Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344957

Summary: [Compatibility] 'Properties' view opens with narrow columns
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3    
Version: 1.0   
Target Milestone: 4.1 RC3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
ActionBars patch v1
none
ToolBar rendering patch v2
none
ActionBars patch v3
none
ActionBars patch v4 none

Description Remy Suen CLA 2011-05-06 08:59:47 EDT 
The 'Properties' view's columns are extremely small when opened which forces the user to resize them.
Comment 1 Remy Suen CLA 2011-05-06 09:04:51 EDT 
Created attachment 194928 [details]
ActionBars patch v1

The bug was introduced by the pack() call from bug 339675. This no longer seems to be necessary anymore. Not clear why at the moment though it could be because of the many tab folder changes that have gone in since then. We'll take it out and continue monitoring how toolbars layout in the coming weeks.
Comment 2 Remy Suen CLA 2011-05-06 09:06:22 EDT 
(In reply to comment #1)
> Created attachment 194928 [details]
> ActionBars patch v1

Patch released to CVS HEAD.
Comment 3 Remy Suen CLA 2011-05-10 10:17:20 EDT 
Now the 'Console' view's tool bar doesn't relayout properly when clearing out stale consoles and launching an application.
Comment 4 Remy Suen CLA 2011-05-10 10:18:34 EDT 
Created attachment 195220 [details]
ToolBar rendering patch v2

Revert attachment 194928 [details] and then change the view rendering code to not use the same parent for the temporary tool bar and the view so that the pack() call doesn't affect the view's content.
Comment 5 Remy Suen CLA 2011-05-10 10:20:44 EDT 
(In reply to comment #4)
> Created attachment 195220 [details]
> ToolBar rendering patch v2

Patch released to CVS HEAD.
Comment 6 Remy Suen CLA 2011-05-17 07:53:24 EDT 
Verified with I20110516-1455 on Windows XP.
Comment 7 Remy Suen CLA 2011-05-24 10:40:07 EDT 
(In reply to comment #3)
> Now the 'Console' view's tool bar doesn't relayout properly when clearing out
> stale consoles and launching an application.

This problem came back with the latest tool bar changes.
Comment 8 Remy Suen CLA 2011-05-24 10:42:24 EDT 
Created attachment 196441 [details]
ActionBars patch v3

Change the code so that we perform a pack() on the tab folder's top right control.
Comment 9 Remy Suen CLA 2011-05-24 11:01:23 EDT 
Created attachment 196445 [details]
ActionBars patch v4

pack() is a method defined in Control. So just call it on the Control instead of checking for Composites.
Comment 10 Remy Suen CLA 2011-05-24 11:04:53 EDT 
(In reply to comment #9)
> Created attachment 196445 [details]
> ActionBars patch v4

Patch released to CVS HEAD.
Comment 11 Remy Suen CLA 2011-06-06 11:19:38 EDT 
Verified with I20110604-2201 on Windows XP.

The new test is also in the build's test results page.