Bug 344925

Comment 1 Nicolas Guyomar 2011-05-11 12:04:47 EDT

Created attachment 195385 [details]
Patch for Bug 344925

Hi Vincent,

Since some actions where executed in two separated commands, this behavior was quite expected.

I merged the command execution so that one action will always be executed in only one command.
There was also a problem with the refresh of the table, which has been solved by enabling the modifications tracking on the tableInstance resource.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 2 Nicolas Guyomar 2011-05-16 05:15:05 EDT

Created attachment 195702 [details]
Patch for Bug 344925 Non regression test

Hi,

Please find attached a non regression test for this bug.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 3 Gregoire Dupe 2011-05-16 10:57:44 EDT

Comment on attachment 195385 [details]
Patch for Bug 344925

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 657.

The SVN diff matches a lot of lines that have not be modified, I hope that this will not break the SVN history.

Comment 4 Gregoire Dupe 2011-05-16 10:59:57 EDT

Comment on attachment 195702 [details]
Patch for Bug 344925 Non regression test

There is a problem with this unit test: it does not fail even if the patch has not be applied. I cannot commit it.

Comment 5 Nicolas Guyomar 2011-05-16 11:07:48 EDT

Created attachment 195739 [details]
Patch for Bug 344925 Non regression test

Hi,

Please find attached an updated version of the test which does fail if we go back to revision 656, and succeed on 657.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 6 Gregoire Dupe 2011-05-16 11:47:10 EDT

Comment on attachment 195739 [details]
Patch for Bug 344925 Non regression test

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 658.

Comment 7 Gregoire Dupe 2011-05-16 11:48:52 EDT

Comment on attachment 195385 [details]
Patch for Bug 344925

The commit of this patch causes a regression: https://hudson.eclipse.org/hudson/job/emffacet-nightly/317/testReport/junit/org.eclipse.emf.facet.widgets.nattable.tests/NatTableShowHideColumnsAPITests/showHideColumnsDeselectAllTest/

Comment 8 Gregoire Dupe 2011-05-16 13:17:18 EDT

Created attachment 195764 [details]
Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest

Here is a patch to fix the regression on Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest.

Comment 9 Gregoire Dupe 2011-05-16 13:19:34 EDT

Comment on attachment 195764 [details]
Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest

I've committed this patch.

(a) I, Gregoire Dupe, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Comment 10 Gregoire Dupe 2011-05-17 04:34:31 EDT

The regression has been fixed. We can then mark this bug as fixed.

Comment 11 Vincent Lorenzo 2011-06-09 04:37:11 EDT

This bug can be marked as closed.