Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344919

Summary:

[cdt] Reuse CDT's Source Not Found Editor

Product:

[Tools] TCF

Reporter:

Anton Leherbauer <aleherb+eclipse>

Component:

Debug

Assignee:

Anton Leherbauer <aleherb+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Eugene Tarassov <eugene>

Severity:

enhancement

Priority:

CC:

cdtdoug

Version:

0.3

Target Milestone:

0.3.1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	aleherb+eclipse: iplog-
Revised patch	aleherb+eclipse: iplog-

Description Anton Leherbauer

2011-05-06 03:40:23 EDT

CDT's CSourceNotFoundEditor provides a button to locate a file and automatically create a source path mapping for it in the launch config.  That's very handy and should be available with the TCF Debugger as well.

Comment 1 Anton Leherbauer

2011-05-06 03:51:52 EDT

Created attachment 194906 [details]
Proposed patch

This patch adds an adapter interface ISourceNotFoundPresentation (similar to ISourcePresentation) which allows to customize the editor used for the source-not-found case.
tcf.cdt implements this adapter to return a slightly customized version of CDT's CSourceNotFoundEditor.

Comment 2 Anton Leherbauer

2011-05-06 07:04:13 EDT

Created attachment 194921 [details]
Revised patch

Fixed: Close editor if launch terminates.

Comment 3 Eugene Tarassov

2011-05-06 13:20:18 EDT

I think it is good to go. Looks great!

Comment 4 Anton Leherbauer

2011-05-09 01:49:14 EDT

Thanks for reviewing. Committed.