Bugzilla – Full Text Bug Listing
| Summary: | EditorSelectionDialog#promptForExternalEditor() leaks an image | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, remy.suen | ||||
| Version: | 3.7 | Flags: | daniel_megert:
review+
|
||||
| Target Milestone: | 3.7 RC1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Good for RC1. Fixed. Thanks for catching and fixing this leak, Markus. Verified in I20110512-2000. This didn't make it into the 4.x stream. Cherry-picked now: Commit df03199b653d305397b221b34d13892698dfb159 |
Created attachment 194859 [details] Fix HEAD EditorSelectionDialog#promptForExternalEditor() leaks an image. To reproduce, choose "Open With > Other... > Browse..." and select a program. java.lang.Error at org.eclipse.swt.graphics.Device.new_Object(Device.java:859) at org.eclipse.swt.graphics.Resource.init(Resource.java:86) at org.eclipse.swt.graphics.Image.<init>(Image.java:492) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:289) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:227) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:205) at org.eclipse.ui.dialogs.EditorSelectionDialog.promptForExternalEditor(EditorSelectionDialog.java:376) at org.eclipse.ui.dialogs.EditorSelectionDialog$DialogListener.handleEvent(EditorSelectionDialog.java:498) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4163) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752) at org.eclipse.jface.window.Window.runEventLoop(Window.java:825) at org.eclipse.jface.window.Window.open(Window.java:801) at org.eclipse.ui.actions.OpenWithMenu$3.handleEvent(OpenWithMenu.java:212)