Bugzilla – Full Text Bug Listing
| Summary: | [ActivityMgmt] Reusing strings with mnemonics and stripping mnemonic does not work in some languages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Grant Taylor <gdtaylor> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ob1.eclipse, prakash, pwebster, remy.suen | ||||
| Version: | 3.4 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
Created attachment 194840 [details]
Screen cap with mnemonic in title
(In reply to comment #0) > To quote our TVT > tester: "Asian languages use addition character as mnemonic during > translation." What are these additional characters? As seen in the screen cap, you can see "(C)" appended as the mnemonic character. From what I understand and I've seen, they are always latin characters in brackets. (In reply to comment #3) > As seen in the screen cap, you can see "(C)" appended as the mnemonic > character. From what I understand and I've seen, they are always latin > characters in brackets. Whoops. I misinterpreted the statement by thinking that the tester meant that they used _additional_ characters (besides an ampersand) for marking something as mnemonics. You're right, the Latin character in question will be surrounded by a pair of parentheses for Asian languages. The ampersand is used for marking something as a mnemonic whereas the parentheses is just there for visual assistance (and presumably to differentiate itself from the other characters). In this case I think the correct fix would be to figure out why something with a mnemonic is being reused for the title of a window and to change it so that it doesn't do use a text string with a mnemonic marker. I agree with what you say. Note that the code was trying to handle the cases where mnemonic-enabled string were string to be inserted. Perhaps this was a band-aid to try and cover up the real issue. (In reply to comment #5) > Note that the code was trying to handle the cases > where mnemonic-enabled string were string to be inserted. Perhaps this was a > band-aid to try and cover up the real issue. It's not entirely clear to me why this was done but it was part of a patch a contributor submitted for bug 68178. I suppose it is possible that the original contributor had a string with a mnemonic on it so the extra code was appended in the method to avoid the problem. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the "stalebug" whiteboard tag. |
Build Identifier: org.eclipse.ui.workbench_3.6.0.I20100603-1100.jar The ActivityCategoryPreferencePage class has this method: /* (non-Javadoc) * @see org.eclipse.jface.window.Window#configureShell(org.eclipse.swt.widgets.Shell) */ protected void configureShell(Shell newShell) { super.configureShell(newShell); String activityName = strings.getProperty(ACTIVITY_NAME, ActivityMessages.ActivityEnabler_activities); activityName = Util.replaceAll(activityName, "&", ""); //strips possible mnemonic //$NON-NLS-1$ //$NON-NLS-2$ newShell.setText(NLS.bind( ActivityMessages.ActivitiesPreferencePage_advancedDialogTitle, activityName )); You can see that there is a line that tries to strip the mnemonic (&) which doesn't work when characters are inserted for some language. To quote our TVT tester: "Asian languages use addition character as mnemonic during translation." Reproducible: Always Steps to Reproduce: 1. Launch Eclipse in Korean locale 2. Go to the workbench preferences, Capabilities page 3. Click on the Advanced... button 4. Note the mnemonic in the window title (will upload screen cap)