Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344768

Summary:

[disassembly] The disassembly view does not respect current line color setting

Product:

[Tools] CDT

Reporter:

Patrick Chuong <pchuong>

Component:

cdt-debug-dsf

Assignee:

Anton Leherbauer <aleherb+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Pawel Piech <pawel.1.piech>

Severity:

normal

Priority:

CC:

cdtdoug

Version:

8.0

Target Milestone:

8.0

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch	pchuong: iplog-
Committed fix	aleherb+eclipse: iplog-

Description Patrick Chuong

2011-05-04 17:21:12 EDT

The disassembly view doesn't use the current "Current line highlight" preference value under "General | Editors | Text Editors" preference, it always use the default value from this perference.

Comment 1 Patrick Chuong

2011-05-04 17:23:55 EDT

Created attachment 194773 [details]
patch

This patch is a simple swap of the editor preference sore and the dsf ui preference fore for the ChainedPreferenceStore object. Without this, the preference value is found in the dsf ui preference store within the ChainedPreferenceStore, which is always the default value.

Comment 2 Anton Leherbauer

2011-05-05 02:54:12 EDT

Created attachment 194794 [details]
Committed fix

Nice find!  I have committed a different fix in the preference initializer.  It was wrong from the beginning to set the editor default preferences in the DSF UI preference store.  Without that it works as expected.

Comment 3 Anton Leherbauer

2011-05-05 02:54:53 EDT

Fixed in HEAD.

Comment 4 CDT Genie

2011-05-05 03:23:03 EDT

*** cdt cvs genie on behalf of aleherbau ***
Bug 344768 - [disassembly] The disassembly view does not respect current line color setting

[*] DisassemblyPreferenceConstants.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/preferences/DisassemblyPreferenceConstants.java?root=Tools_Project&r1=1.3&r2=1.4