Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344746

Summary: [client] git push does not appear for all the folder and file levels
Product: [ECD] Orion Reporter: Nayna Jain <jainnayna>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, malgorzata.tomczyk, simon_kaegi, Szymon.Brandys
Version: 0.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Nayna Jain CLA 2011-05-04 13:44:31 EDT
Hi,

I have linked the Orion client clone repository to the folder "OrionClient".
I wanted to try the push feature from Orion.
I did a small change in about.html and have staged, commited it.
Now, for "about.html" when I clicked on More->Git Log.. I didn't find the "Push" button on the toolbar
Similarly, I didn't find it at any of its parent folder level.
Only at "OrionClient" folder when I clicked on More->Git Log, that I found the "Push" button.

Is this the way it is supposed to work or is a bug ?

I think "Push" button should be visible on all the folders/files level.

Thanks & Regards,
      - Nayna Jain
Comment 1 Boris Bokowski CLA 2011-05-05 23:12:32 EDT
We're still debating this, but the push action is currently available only on the Git Log page for the whole repository. I don't think it is available on the Git Log page for a single file.
Comment 2 Susan McCourt CLA 2011-05-05 23:37:03 EDT
I think I may have supported this restriction early on (worried about "blind push").  But now, I feel differently.  If you clone (or link to a clone) at the top level repository, but commonly work within a subfolder (such as org.eclipse.orion.client.core) then it's really reasonable to want to push from there.  

Something is not feeling right to me in our git workflow right now.  We give all this granular navigator command functionality, but if we aren't going to let you do anything once you get there, maybe we should rethink what's happening underneath.

For example, maybe git log shows the log for the whole repo in which the file is located and there is another gesture (or sort order) if you are really wanting to know only about one folder.
Comment 3 Boris Bokowski CLA 2011-05-06 00:15:16 EDT
(In reply to comment #2)
> Something is not feeling right to me in our git workflow right now.

Good to know that I am not the only one :-)

I've been meaning to post mockups for how I think the Git UI should be structured into pages, and which functionality belongs to which page. I still plan on doing that, please keep reminding me if I keep postponing it :-)
Comment 4 Szymon Brandys CLA 2015-04-01 10:22:41 EDT
Invalid.