Bugzilla – Full Text Bug Listing
| Summary: | RejectedExecutionException thrown when terminating a launch | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Norman Yee <normankyee> |
| Component: | cdt-debug-dsf | Assignee: | Marc Khouzam <marc.khouzam> |
| Status: | RESOLVED FIXED | QA Contact: | Pawel Piech <pawel.1.piech> |
| Severity: | normal | ||
| Priority: | P3 | CC: | andrew.mclachlan, cdtdoug, marc.khouzam, nobody |
| Version: | 7.0 | ||
| Target Milestone: | 8.5 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Norman Yee
I can reproduce the problem with the PDA DSF example. Just launch a PDA launch configuration, terminate it, and you'll see the RejectedExecutionException exception in the Error Log view. Any news on a fix for this Issue? I can reproduce this with the PDA launch. The problem is that the DSF executor is being shutdown too early. When the platform makes calls to update the UI buttons after the launch is terminated, the executor is not there any more and the exception is thrown. In GdbLaunch, we only shutdown the executor when the launch is removed from the debug view, not when the launch is terminated. I pushed a patch to Gerrit to do the same in the PDA launch: https://git.eclipse.org/r/29488 My guess is that your custom DSF debugger makes the same mistake. Mikhail, I believe you use the PDA example once in a while, can you have a look at this fix? It is a couple of lines only and maps directly to what we don in GdbLaunch. (In reply to Marc Khouzam from comment #4) > Mikhail, I believe you use the PDA example once in a while, can you have a > look at this fix? It is a couple of lines only and maps directly to what we > don in GdbLaunch. Mark, I have never been able to make the PDA example run. I can review the code without trying it though. (In reply to Mikhail Khodjaiants from comment #5) > (In reply to Marc Khouzam from comment #4) > > Mikhail, I believe you use the PDA example once in a while, can you have a > > look at this fix? It is a couple of lines only and maps directly to what we > > don in GdbLaunch. > > Mark, I have never been able to make the PDA example run. Yeah, I'm not very familiar with it. This is what I did: 1- create test.pl at the root of any of your test projects with the line: print allo 2- create a new launch configuration using the PDA launch configuration type. 3- use test.pl as the program in the Main tab (e.g., /HelloWorld/test.pl) 4- launch Not everything seems to work, but it does launch for me > I can review the code without trying it though. That is fine for me. The change is in an example and a copy of code we know works. Thanks Marc! I applied the same fix to my debugger plugin and I don't see the exception any more. (In reply to Norman Yee from comment #7) > Thanks Marc! I applied the same fix to my debugger plugin and I don't see > the exception any more. That is great. I think that confirms the validity of the fix so I have committed it to master. Mikhail, that should save you some time as this review was not very important, but your comments are always welcomed, as usual. |