Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344704

Summary: 'Paste Repository Path' command hijacks Ctrl+V forever
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Paul Webster <pwebster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, pwebster
Version: 1.0   
Target Milestone: 4.1 RC2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 331240    
Attachments:
Description Flags
activate and de-activate v01 none

Description Remy Suen CLA 2011-05-04 09:45:58 EDT
After accessing the 'Git Repository Exploring' perspective, Ctrl+V will no longer paste stuff properly as it keeps trying to paste it as a repository path (for Git). Unbinding the command in the 'Keys' preference page will workaround this problem.
Comment 1 Paul Webster CLA 2011-05-04 09:57:30 EDT
Hi Chris,

I see org.eclipse.egit.ui.internal.repository.RepositoriesView activates the context org.eclipse.egit.ui.RepositoriesView.

Do you know if anything else in egit.ui does?

It looks like we haven't tied our e4 context service activation/deactivation to core expressions in org.eclipse.ui.internal.contexts.ContextService.activateContext(String, Expression)

PW
Comment 2 Remy Suen CLA 2011-05-04 10:12:14 EDT
Probably the same problem as bug 344698.
Comment 3 Paul Webster CLA 2011-05-17 14:48:56 EDT
Created attachment 195904 [details]
activate and de-activate v01

If we are activating a context with an expression, make sure we honour the expression.

PW
Comment 4 Paul Webster CLA 2011-05-17 14:49:15 EDT
Released to HEAD
PW