Bugzilla – Full Text Bug Listing
| Summary: | [cdt] Provide "Add Watchpoint" in Editor, Variables and Expressions view | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] TCF | Reporter: | Anton Leherbauer <aleherb+eclipse> | ||||
| Component: | Debug | Assignee: | Project Inbox <tcf.debug-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Eugene Tarassov <eugene> | ||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | cdtdoug | ||||
| Version: | 0.3 | ||||||
| Target Milestone: | 0.4.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Could you comment on changes in TCFNodeExpression class? The new cache item "expression_text" seems to compute same data as "text" with only minor difference. Actually "text" seems doing it a little bit better. Can we reuse "text" instead of "expression_text"? (In reply to comment #1) > Could you comment on changes in TCFNodeExpression class? > > The new cache item "expression_text" seems to compute same data as "text" with > only minor difference. Actually "text" seems doing it a little bit better. Can > we reuse "text" instead of "expression_text"? I did try with "text" first, but it does not include the parent expression and it does not resolve symbol names. Sorry, the changes are already committed, because I did not get a notification from bugzilla about your comment. I'll leave the bug open for now. > ... it does not resolve symbol names.
If you mean it uses IDs instead of names - it is intensional. Names can be ambiguous. IDs instead of names is an extension of the expression syntax. Anyway, I think it is OK for now. I will have another look at the code when I have more time.
I think this can be closed now. |
Created attachment 194714 [details] Patch This patch adds "Add Watchpoint" menu items to the Editor and Variables and Expressions view. For the Variables and Expressions view we reuse the CDT action. For the editor we contribute a command handler restricted to TCF, i.e. the menu item is only visible when a TCF session is active.