Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344698

Summary: [Compatibility] Undo sometimes suddenly stops working
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: Olivier_Thomann, pwebster
Version: 1.0   
Target Milestone: 4.1 RC1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Context service handling patch v1
none
PageSite patch v2 none

Description Remy Suen CLA 2011-05-04 09:16:49 EDT 
Both Olivier and I have seen this problem from time to time. It seems if I unbind the 'EOF' command in the 'Keys' preference page (which is mapped to Ctrl+Z) then the problem goes away.
Comment 1 Remy Suen CLA 2011-05-04 10:12:05 EDT 
Probably the same problem as bug 344704.
Comment 2 Remy Suen CLA 2011-05-04 12:37:14 EDT 
1. Open a Java file.
2. Make the file dirty.
3. Ctrl+Z. It works as expected.
4. Run a program that prints to the console.
5. Activate the 'Console' view.
6. Click the 'Remove All Terminated Launches' tool item.
7. Activate the editor.
8. Make the file dirty.
9. Ctrl+Z doesn't work anymore. The workaround described in comment 0 resolves the problem.
Comment 3 Remy Suen CLA 2011-05-04 14:35:26 EDT 
Created attachment 194751 [details]
Context service handling patch v1

This patch changes the part sites and page sites to have their own implementation of IContextService. This fixes the problem described by comment 2 and allows Ctrl+V to work again (see bug 344704) if the 'Git Repositories' view is closed.
Comment 4 Remy Suen CLA 2011-05-04 14:39:48 EDT 
(In reply to comment #3)
> Created attachment 194751 [details]
> Context service handling patch v1

I've released this patch to HEAD but there are technically still some code changes necessary. That will be covered by bug 344704.
Comment 5 Remy Suen CLA 2011-05-11 11:06:29 EDT 
Created attachment 195371 [details]
PageSite patch v2

Unfortunately, it seems I broke Ctrl+Z in 'Console' views in general. This patch will fix the problem.

Also uncovered bug 345435 but that seems to be broken in 3.x too. Will have to monitor it closely and see what's going on here.
Comment 6 Remy Suen CLA 2011-05-11 11:07:02 EDT 
(In reply to comment #5)
> Created attachment 195371 [details]
> PageSite patch v2

Patch released to CVS HEAD.
Comment 7 Remy Suen CLA 2011-05-17 08:14:50 EDT 
Verified with I20110516-1455 on Windows XP.