Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344680

Summary: Improve rendering of Tree#dispose
Product: [RT] RAP Reporter: Ralf Sternberg <rsternberg>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: tbuschto
Version: 1.4   
Target Milestone: 1.5 M7   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Ralf Sternberg CLA 2011-05-04 05:58:30 EDT
The disposal of a Tree with many items already materialized results in long protocol messages.
But there seems to be no need to render a dispose call for every single TreeItem when the Tree is disposed. I'd suggest to check in the TreeItemLCA for the parent TreeItem (or the Tree if top-level) being disposed and if so, omit the dispose call. The client side can recursively dispose all child TreeItems.
Comment 1 Ivan Furnadjiev CLA 2012-04-04 04:51:12 EDT
The implementation in TreeItemLCA#renderDispose was already there. Changed TreeItemAdapter#isParentDisposed to respect parent item as well. JUnit tests added. Changes are in CVS HEAD.