Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344574

Summary: [target] p2 target locations should use metadata from install locations
Product: [Eclipse Project] PDE Reporter: DJ Houghton <dj.houghton>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: curtis.windatt.public, jeffmcaffer, pwebster
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard: stalebug

Description DJ Houghton CLA 2011-05-03 09:55:23 EDT
Eclipse build
Version: 4.1.0
Build id: I20110501-0200

I'm trying to update the Platform to use ECF 3.5 (bug 341290) so I am trying to add ECF 3.5 to my Target Platform to ensure our tests run, our manifest version ranges are ok, etc. But when I try to add ECF to the target platform, I get errors and it won't add.

- Preferences -> Target Platform -> Edit -> Add 
- add http://download.eclipse.org/rt/ecf/3.5/site.p2 (as referenced http://www.eclipse.org/ecf/downloads.php)
- Group By Category
- Select the ECF category
- Hit Finish

It says it can't add ECF Core because it can't find equinox.common. But it does exist in my other location in the target platform.

I've also tried this with the ECF zip (available from the same download page) but have the same results.
Comment 1 Curtis Windatt CLA 2011-05-03 11:00:34 EDT
Is your other location an install or directory location?  The p2 repository locations are unable to use the plug-ins from those types of locations as it does not have the necessary metadata.
Comment 2 DJ Houghton CLA 2011-05-03 11:02:58 EDT
The other location is the default... ${eclipse_home}. Can't the metadata come from the running profile?
Comment 3 Curtis Windatt CLA 2011-05-03 11:23:52 EDT
I thought we had a bug for this, but I can't find it.  You have a couple workarounds, remove the ${eclipse_home} and add another p2 location pointing at your install, or in your existing p2 location turn off 'include required software' so the slicer is used instead of the planner.
Comment 4 DJ Houghton CLA 2011-05-03 11:27:24 EDT
Ok, thanks. I've actually decided to take option 3 and roll the dice and install ECF 3.5 into my installation and run with it. What's the worst that could happen? ;-)
Comment 5 DJ Houghton CLA 2011-05-03 11:44:58 EDT
(In reply to comment #3)
> I thought we had a bug for this, but I can't find it.  You have a couple
> workarounds, remove the ${eclipse_home} and add another p2 location pointing at
> your install, or in your existing p2 location turn off 'include required
> software' so the slicer is used instead of the planner.

I actually tried adding a new location based off my install and I get the same error.

Where can I find the "include required software" preference? I don't see it in the Target Platform dialogs.
Comment 6 Curtis Windatt CLA 2011-05-03 11:46:30 EDT
Double click on your p2 location (opens the edit wizard).  At the bottom there are some check boxes.
Comment 7 Jeff McAffer CLA 2011-05-03 12:20:36 EDT
Yeah, it might be interesting to treat a p2-based install bundle container specially here.  There would be a host of special cases though.  Basically we have the metadata etc but the provisioning operations associated with the IUBundleContainers are expecting to download things into the pde bundle pool.  We may be able to add the install bundle pool to the pde profile's bundle pool such that it is not written into.  Would need to take care wrt garbage collection etc.

Summary, great idea, likely non-trivial work.
Comment 8 Lars Vogel CLA 2019-11-14 02:22:36 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.