Bugzilla – Full Text Bug Listing
| Summary: | NPE with Enum Editor | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Vincent Lorenzo <vincent.lorenzo> | ||||||||||||||||||
| Component: | EMF-Facet | Assignee: | Gregoire Dupe <gdupe> | ||||||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||||||||
| Severity: | normal | ||||||||||||||||||||
| Priority: | P2 | CC: | emft.facet-inbox, gdupe, vincent.lorenzo | ||||||||||||||||||
| Version: | unspecified | Flags: | gdupe:
indigo+
|
||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||
| OS: | Windows XP | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Vincent Lorenzo
Created attachment 194572 [details]
Correct the NPE with Enum Editor
(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.
Created attachment 195363 [details]
Meta-model project to reproduce the bug.
Hello,
Here is a meta-model project to reproduce the bug.
(1) I, Gregoire Dupe, wrote 100% of the code.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.
Regards,
Gregoire Dupe
Created attachment 195365 [details]
A model to reproduce the bug
Hello,
Here is a model to reproduce the bug.
(1) I, Gregoire Dupe, wrote 100% of the code.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.
Regards,
Gregoire Dupe
Comment on attachment 194572 [details]
Correct the NPE with Enum Editor
Hello,
With this patch a warning message pops up. I’ll commit fix which avoid the warning pop-up message.
Regards,
Gregoire Dupe
I fixed this bug. Committed revision 643. Regards, Gregoire Dupe A non regression is still missing. Created attachment 195704 [details] New Plugin : org.eclipse.emf.facet.widgets.nattable.tests.bug344563.zip Hi, Please find attached a new plug-in which contains the implementation of a metamodel dedicated to reproduce this bug. The authors are Gregoire Dupe (commiter) and myself : (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Created attachment 195706 [details] Patch for Bug 344563 Non regression test Hi, Please find attached a non regression test for this bug. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Created attachment 195824 [details] Patch for Bug 344563 ENumComposite Hi, I need to enable the user to press 'Enter' key to validate its choice while using the EnumCellEditor, as well as the 'Cancel' key to cancel the edition of the cell Here is a patch which add a keyListener (same listener as the other cellEditor) to the ENumComposite's comboBox (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Comment on attachment 195704 [details] New Plugin : org.eclipse.emf.facet.widgets.nattable.tests.bug344563.zip Here is a contribution from one employee of Mia-Software and of my self, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 666. Comment on attachment 195706 [details] Patch for Bug 344563 Non regression test Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 667. Comment on attachment 195824 [details] Patch for Bug 344563 ENumComposite Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 667. This bug can be marked as resolved. Created attachment 195841 [details] Patch for Bug 344563 Linux Compatibility Hi, The non regression test is failing on Hudson because there is a difference between Linux and Windows way of activating the ENumCoposite. On Windows when we edit an enum cell, the comboBox's content is automatically selected so that when we type it erases the previous content. On Linux the comboBox's content is not selected, and we add what we type to the current content. This patch initialize the content a the comboBox with an empty String, so that the test behave the same way on both platform. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Created attachment 195845 [details] Patch for Bug 344563 Linux Compatibility Updated version of the fix for Linux without warnings (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar Hello, I reopen this bug to remember that the attachment 195845 [details] has to committed after the build of 0.1.0. RC1. The attachment 195845 [details] is a patch of a unit test class and not of a component provided to the user. Regards, Gregoire Dupe Comment on attachment 195845 [details] Patch for Bug 344563 Linux Compatibility Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). The unit test org.eclipse.emf.facet.widgets.nattable.tests.swtbot.Bug344563Test.testBug344563 is still failing on Hudson.eclipse.org. I’ve then committed this patch without any PMC review in conformance with http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg02061.html Committed revision 689. Regards, Gregoire Dupe The build https://hudson.eclipse.org/hudson/job/emffacet-nightly/351/ runs without any test failure. This bug can then be marked as fixed. The corresponding unit test succeed in https://hudson.eclipse.org/hudson/job/emffacet-nightly/355/testReport/org.eclipse.emf.facet.widgets.nattable.tests.swtbot/Bug344563Test/. We can then close this bug. |